ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-08-23 15:20:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor: Retire fix1578 amendment (#5927)

Browse Source 
Amendments activated for more than 2 years can be retired. This change retires the fix1578 amendment.
This commit is contained in:
Pratik Mankawde
2025-10-29 16:08:17 +00:00
committed by GitHub
parent bd3bc917f8
commit efa917d9f3
7 changed files with 158 additions and 188 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/test/app/Offer_test.cpp
View File

@@ -846,13 +846,8 @@ public:
// Fill or Kill - unless we fully cross, just charge a fee and don't
// place the offer on the books. But also clean up expired offers
// that are discovered along the way.
//
// fix1578 changes the return code. Verify expected behavior
// without and with fix1578.
for (auto const& tweakedFeatures :
{features - fix1578, features | fix1578})
{
Env env{*this, tweakedFeatures};
Env env{*this, features};
auto const f = env.current()->fees().base;
@@ -878,9 +873,7 @@ public:
// Order that can't be filled but will remove bob's expired offer:
{
TER const killedCode{
tweakedFeatures[fix1578] ? TER{tecKILLED}
: TER{tesSUCCESS}};
TER const killedCode{TER{tecKILLED}};
env(offer(alice, XRP(1000), USD(1000)),
txflags(tfFillOrKill),
ter(killedCode));
@@ -3008,8 +3001,7 @@ public:
env.close();
// Code returned if an offer is killed.
TER const killedCode{
features[fix1578] ? TER{tecKILLED} : TER{tesSUCCESS}};
TER const killedCode{TER{tecKILLED}};
// bob offers XRP for USD.
env(trust(bob, USD(200)));