chore: Update Visual Studio CI to VS 2022, and add VS Debug builds (#5240)

* Debug builds do not run tests, because they take too long.

.github/workflows/windows.yml

@@ -24,16 +24,18 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        generator:
+        version:
-          - Visual Studio 16 2019
+          - generator: Visual Studio 17 2022
+            runs-on: windows-2022
         configuration:
-          - Release
+          - type: Release
-          # Github hosted runners tend to hang when running Debug unit tests.
+            tests: true
-          # Instead of trying to work around it, disable the Debug job until
+          - type: Debug
-          # something beefier (i.e. a heavy self-hosted runner) becomes
+            # Skip running unit tests on debug builds, because they
-          # available.
+            # take an unreasonable amount of time
-          # - Debug
+            tests: false
-    runs-on: windows-2019
+            runtime: d
+    runs-on: ${{ matrix.version.runs-on }}
     env:
       build_dir: .build
     steps:
@@ -68,7 +70,9 @@ jobs:
         run: |
           conan profile new default --detect
           conan profile update settings.compiler.cppstd=20 default
-          conan profile update settings.compiler.runtime=MT${{ matrix.configuration == 'Debug' && 'd' || '' }} default
+          conan profile update \
+            settings.compiler.runtime=MT${{ matrix.configuration.runtime }} \
+            default
       - name: build dependencies
         uses: ./.github/actions/dependencies
         env:
@@ -76,16 +80,18 @@ jobs:
           CONAN_LOGIN_USERNAME_RIPPLE: ${{ secrets.CONAN_USERNAME }}
           CONAN_PASSWORD_RIPPLE: ${{ secrets.CONAN_TOKEN }}
         with:
-          configuration: ${{ matrix.configuration }}
+          configuration: ${{ matrix.configuration.type }}
       - name: build
         uses: ./.github/actions/build
         with:
-          generator: '${{ matrix.generator }}'
+          generator: '${{ matrix.version.generator }}'
-          configuration: ${{ matrix.configuration }}
+          configuration: ${{ matrix.configuration.type }}
           # Hard code for now. Move to the matrix if varied options are needed
           cmake-args: '-Dassert=ON -Dreporting=OFF -Dunity=ON'
           cmake-target: install
       - name: test
         shell: bash
+        if: ${{ matrix.configuration.tests }}
         run: |
-          ${build_dir}/${{ matrix.configuration }}/rippled --unittest --unittest-jobs $(nproc)
+          ${build_dir}/${{ matrix.configuration.type }}/rippled --unittest \
+              --unittest-jobs $(nproc)