From ebc5c5ed9d9e4b87592e2c95ab86d1f605a5a958 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Thu, 4 Jun 2026 14:36:04 +0100 Subject: [PATCH] fix(telemetry): set service_instance_id in [insight] so dashboards filter MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit beast::insight metrics exported via OTLP carried no exported_instance label because [insight] omitted service_instance_id (only [telemetry] set it). Every system-* dashboard filters insight metrics with exported_instance=~"$node", and the $node template variable is sourced from label_values(..., exported_instance) — so with the label absent, $node was empty and all insight-backed panels showed no data. Add service_instance_id to [insight] in both telemetry configs, matching the [telemetry] value (xrpld-mainnet / xrpld-devnet). CollectorManager already reads this key and passes it to OTelCollector, which sets the service.instance.id resource attribute. Co-Authored-By: Claude Opus 4.6 --- docker/telemetry/xrpld-telemetry-mainnet.cfg | 5 +++++ docker/telemetry/xrpld-telemetry.cfg | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/docker/telemetry/xrpld-telemetry-mainnet.cfg b/docker/telemetry/xrpld-telemetry-mainnet.cfg index 5a6a4ee639..4393ad398a 100644 --- a/docker/telemetry/xrpld-telemetry-mainnet.cfg +++ b/docker/telemetry/xrpld-telemetry-mainnet.cfg @@ -111,6 +111,11 @@ docker/telemetry/data server=otel endpoint=http://localhost:4318/v1/metrics prefix=xrpld +# Sets the OTel service.instance.id resource attribute, which Prometheus +# exposes as the `exported_instance` label. Dashboards filter on it via the +# $node template variable, so without this every insight-backed panel is +# empty. Matches [telemetry] service_instance_id for a single node identity. +service_instance_id=xrpld-mainnet # --- OpenTelemetry tracing -------------------------------------------------- diff --git a/docker/telemetry/xrpld-telemetry.cfg b/docker/telemetry/xrpld-telemetry.cfg index 453fe50439..a302faa2f5 100644 --- a/docker/telemetry/xrpld-telemetry.cfg +++ b/docker/telemetry/xrpld-telemetry.cfg @@ -109,6 +109,11 @@ docker/telemetry/data server=otel endpoint=http://localhost:4318/v1/metrics prefix=xrpld +# Sets the OTel service.instance.id resource attribute, which Prometheus +# exposes as the `exported_instance` label. Dashboards filter on it via the +# $node template variable, so without this every insight-backed panel is +# empty. Matches [telemetry] service_instance_id for a single node identity. +service_instance_id=xrpld-devnet # --- OpenTelemetry tracing --------------------------------------------------