Remove OwnerPaysFee as it's never fully supported (#5435)

The OwnerPaysFee amendment was never fully supported, and this change removes the feature to the extent possible.
This commit is contained in:
Jingchen
2025-06-24 19:56:58 +01:00
committed by GitHub
parent 42fd74b77b
commit e9d46f0bfc
9 changed files with 27 additions and 439 deletions

View File

@@ -254,7 +254,7 @@ FeatureCollections::registerFeature(
{
check(!readOnly, "Attempting to register a feature after startup.");
check(
support == Supported::yes || vote == VoteBehavior::DefaultNo,
support == Supported::yes || vote != VoteBehavior::DefaultYes,
"Invalid feature parameters. Must be supported to be up-voted.");
Feature const* i = getByName(name);
if (!i)
@@ -268,7 +268,7 @@ FeatureCollections::registerFeature(
features.emplace_back(name, f);
auto const getAmendmentSupport = [=]() {
if (vote == VoteBehavior::Obsolete)
if (vote == VoteBehavior::Obsolete && support == Supported::yes)
return AmendmentSupport::Retired;
return support == Supported::yes ? AmendmentSupport::Supported
: AmendmentSupport::Unsupported;