From e63ca4c495635f5d7094cbfa6c702ed1eeb19c45 Mon Sep 17 00:00:00 2001
From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Date: Tue, 31 Mar 2026 13:46:52 +0100
Subject: [PATCH] fix(telemetry): fix dashboard UID and add parity attributes
 to expected_spans

- Remove duplicate 'system-node-health' UID from expected_metrics.json
  (already covered by 'rippled-system-node-health')
- Add parity span attributes to expected_spans.json: node health on
  rpc.command.*, validation hash/full on consensus.validation.send,
  quorum/proposers on consensus.accept, validation hash/full on
  peer.validation.receive

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 .../telemetry/workload/expected_metrics.json  |  3 +--
 docker/telemetry/workload/expected_spans.json | 23 +++++++++++++++----
 2 files changed, 19 insertions(+), 7 deletions(-)

diff --git a/docker/telemetry/workload/expected_metrics.json b/docker/telemetry/workload/expected_metrics.json
index d79d2c776f..318d346580 100644
--- a/docker/telemetry/workload/expected_metrics.json
+++ b/docker/telemetry/workload/expected_metrics.json
@@ -133,8 +133,7 @@
       "rippled-system-overlay-detail",
       "rippled-system-ledger-sync",
       "rippled-validator-health",
-      "rippled-peer-quality",
-      "system-node-health"
+      "rippled-peer-quality"
     ]
   }
 }
diff --git a/docker/telemetry/workload/expected_spans.json b/docker/telemetry/workload/expected_spans.json
index 70c2954ee5..5932788938 100644
--- a/docker/telemetry/workload/expected_spans.json
+++ b/docker/telemetry/workload/expected_spans.json
@@ -31,7 +31,9 @@
         "xrpl.rpc.version",
         "xrpl.rpc.role",
         "xrpl.rpc.status",
-        "xrpl.rpc.duration_ms"
+        "xrpl.rpc.duration_ms",
+        "xrpl.node.amendment_blocked",
+        "xrpl.node.server_state"
       ],
       "config_flag": "trace_rpc",
       "note": "Wildcard — matches rpc.command.server_info, rpc.command.ledger, etc."
@@ -87,7 +89,11 @@
       "name": "consensus.accept",
       "category": "consensus",
       "parent": null,
-      "required_attributes": ["xrpl.consensus.proposers"],
+      "required_attributes": [
+        "xrpl.consensus.proposers",
+        "xrpl.consensus.validation_quorum",
+        "xrpl.consensus.proposers_validated"
+      ],
       "config_flag": "trace_consensus"
     },
     {
@@ -96,7 +102,9 @@
       "parent": null,
       "required_attributes": [
         "xrpl.consensus.ledger.seq",
-        "xrpl.consensus.proposing"
+        "xrpl.consensus.proposing",
+        "xrpl.validation.ledger_hash",
+        "xrpl.validation.full"
       ],
       "config_flag": "trace_consensus"
     },
@@ -153,7 +161,12 @@
       "name": "peer.validation.receive",
       "category": "peer",
       "parent": null,
-      "required_attributes": ["xrpl.peer.id", "xrpl.peer.validation.trusted"],
+      "required_attributes": [
+        "xrpl.peer.id",
+        "xrpl.peer.validation.trusted",
+        "xrpl.peer.validation.ledger_hash",
+        "xrpl.peer.validation.full"
+      ],
       "config_flag": "trace_peer"
     }
   ],
@@ -177,5 +190,5 @@
     }
   ],
   "total_span_types": 17,
-  "total_unique_attributes": 29
+  "total_unique_attributes": 37
 }