Merge branch 'ximinez/lending-refactoring-1' into ximinez/lending-refactoring-2

src/test/app/Delegate_test.cpp

@@ -1499,4 +1499,4 @@ class Delegate_test : public beast::unit_test::suite
 };
 BEAST_DEFINE_TESTSUITE(Delegate, app, ripple);
 }  // namespace test
-}  // namespace ripple
+}  // namespace ripple

src/test/app/NFTokenAuth_test.cpp

@@ -621,4 +621,4 @@ public:
 
 BEAST_DEFINE_TESTSUITE_PRIO(NFTokenAuth, app, ripple, 2);
 
-}  // namespace ripple
+}  // namespace ripple

src/test/csf/collectors.h

@@ -720,4 +720,4 @@ struct JumpCollector
 }  // namespace test
 }  // namespace ripple
 
-#endif
+#endif

src/test/jtx/delegate.h

@@ -59,4 +59,4 @@ public:
 }  // namespace delegate
 }  // namespace jtx
 }  // namespace test
-}  // namespace ripple
+}  // namespace ripple

src/test/jtx/impl/Env.cpp

@@ -507,7 +507,16 @@ Env::meta()
         close();
     }
     auto const item = closed()->txRead(txid_);
-    return item.second;
+    auto const result = item.second;
+    if (result == nullptr)
+    {
+        test.log << "Env::meta: no metadata for txid: " << txid_ << std::endl;
+        test.log << "This is probably because the transaction failed with a "
+                    "non-tec error."
+                 << std::endl;
+        Throw<std::runtime_error>("Env::meta: no metadata for txid");
+    }
+    return result;
 }
 
 std::shared_ptr<STTx const>

src/test/jtx/impl/delegate.cpp

@@ -64,4 +64,4 @@ entry(jtx::Env& env, jtx::Account const& account, jtx::Account const& authorize)
 }  // namespace delegate
 }  // namespace jtx
 }  // namespace test
-}  // namespace ripple
+}  // namespace ripple

src/xrpld/app/tx/detail/DelegateSet.cpp

@@ -159,4 +159,4 @@ DelegateSet::deleteDelegate(
     return tesSUCCESS;
 }
 
-}  // namespace ripple
+}  // namespace ripple

src/xrpld/app/tx/detail/DelegateSet.h

@@ -53,4 +53,4 @@ public:
 
 }  // namespace ripple
 
-#endif
+#endif