From e3c2f8279a31daea26e2a6d4bd5161944c0243b6 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Mon, 27 Jul 2026 20:45:04 +0100 Subject: [PATCH] fix(test): use SuiteJournal and drop an unused local beast::Journal has no default constructor, so holding one as a plain member deleted the suite's own default constructor and the Beast registration macro could not instantiate it. SuiteJournal takes the suite, converts implicitly where a journal is expected, and routes log output into the test report. Also removes a leftover unused local in run(), which is a hard error under the warnings-as-errors build. Co-Authored-By: Claude Opus 5 (1M context) --- src/test/nodestore/DatabaseConfig_test.cpp | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/test/nodestore/DatabaseConfig_test.cpp b/src/test/nodestore/DatabaseConfig_test.cpp index 13f52159ec..71168461b3 100644 --- a/src/test/nodestore/DatabaseConfig_test.cpp +++ b/src/test/nodestore/DatabaseConfig_test.cpp @@ -1,6 +1,7 @@ #include #include #include +#include #include @@ -41,9 +42,11 @@ private: * * The nodestore suites that used to share these helpers moved to GTest, * taking their common base with them. This suite stayed on Beast, so it - * keeps its own copy of the few pieces it needs. + * keeps its own copy of the few pieces it needs. SuiteJournal rather than + * a bare beast::Journal, which has no default constructor; it converts + * implicitly where a journal is expected. */ - beast::Journal journal_; + test::SuiteJournal journal_{"DatabaseConfig_test", *this}; /** * Build a batch of node objects that is the same for a given seed. @@ -855,8 +858,6 @@ public: void run() override { - std::int64_t const seedValue = 50; - testCounterWidths(); testDurationAccessors();