From e31419aa062cc8cccd9ca22de436741892f7652c Mon Sep 17 00:00:00 2001 From: Bart <11445373+bthomee@users.noreply.github.com> Date: Tue, 21 Apr 2026 11:08:02 -0700 Subject: [PATCH] Address Copilot feedback --- src/xrpld/app/ledger/detail/TransactionAcquire.cpp | 2 +- src/xrpld/overlay/detail/PeerImp.cpp | 7 ++----- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/xrpld/app/ledger/detail/TransactionAcquire.cpp b/src/xrpld/app/ledger/detail/TransactionAcquire.cpp index 0ba53095ce..77d314fb1a 100644 --- a/src/xrpld/app/ledger/detail/TransactionAcquire.cpp +++ b/src/xrpld/app/ledger/detail/TransactionAcquire.cpp @@ -198,7 +198,7 @@ TransactionAcquire::takeNodes( ConsensusTransSetSF sf(app_, app_.getTempNodeCache()); - for (auto& d : data) + for (auto const& d : data) { if (d.first.isRoot()) { diff --git a/src/xrpld/overlay/detail/PeerImp.cpp b/src/xrpld/overlay/detail/PeerImp.cpp index 810155a414..dcbfada66b 100644 --- a/src/xrpld/overlay/detail/PeerImp.cpp +++ b/src/xrpld/overlay/detail/PeerImp.cpp @@ -3465,11 +3465,8 @@ PeerImp::processLedgerRequest(std::shared_ptr const& m) ++i) { auto const shaMapNodeId{deserializeSHAMapNodeID(m->nodeids(i))}; - if (!shaMapNodeId.has_value()) - { - JLOG(p_journal_.error()) << "processLedgerRequest: Invalid SHAMap node ID"; - return; - } + XRPL_ASSERT( + shaMapNodeId.has_value(), "xrpl::PeerImp::processLedgerRequest : valid node ID"); data.clear(); data.reserve(Tuning::softMaxReplyNodes);