ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Enforce account RPC limits by account objects traversed

Browse Source
This commit is contained in:
natenichols
2021-12-15 18:56:49 -06:00
committed by manojsdoshi
parent 915fe31274
commit e28989638d
9 changed files with 358 additions and 154 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
src/test/rpc/AccountOffers_test.cpp
View File

@@ -81,7 +81,8 @@ public:
"json", "account_offers", jvParams.toStyledString())[jss::result];
auto const& jro_l = jrr_l[jss::offers];
BEAST_EXPECT(checkMarker(jrr_l));
BEAST_EXPECT(checkArraySize(jro_l, 10u));
// 9u is the expected size, since one account object is a trustline
BEAST_EXPECT(checkArraySize(jro_l, 9u));
}
void
@@ -173,6 +174,7 @@ public:
// last item...with previous marker passed
jvParams[jss::marker] = jrr_l_2[jss::marker];
jvParams[jss::limit] = 10u;
auto const jrr_l_3 = env.rpc(
"json",
"account_offers",
@@ -203,9 +205,17 @@ public:
"account_offers",
jvParams.toStyledString())[jss::result];
auto const& jro = jrr[jss::offers];
BEAST_EXPECT(checkArraySize(jro, asAdmin ? 0u : 3u));
BEAST_EXPECT(
asAdmin ? checkMarker(jrr) : (!jrr.isMember(jss::marker)));
if (asAdmin)
{
// limit == 0 is invalid
BEAST_EXPECT(jrr.isMember(jss::error_message));
}
else
{
// Call should enforce min limit of 10
BEAST_EXPECT(checkArraySize(jro, 3u));
BEAST_EXPECT(!jrr.isMember(jss::marker));
}
}
}