chore: Enable most readability checks (#7772)

This commit is contained in:
Ayaz Salikhov
2026-07-14 13:21:40 +01:00
committed by GitHub
parent acd54fd627
commit e1d4f357dc
42 changed files with 102 additions and 887 deletions

View File

@@ -150,7 +150,7 @@ public:
{
auto member = c->member(node);
BEAST_EXPECT(static_cast<bool>(member));
BEAST_EXPECT(member->compare(name) == 0); // NOLINT(bugprone-unchecked-optional-access)
BEAST_EXPECT(*member == name); // NOLINT(bugprone-unchecked-optional-access)
}
// Updating the name (non-empty doesn't go to empty)
@@ -159,7 +159,7 @@ public:
{
auto member = c->member(node);
BEAST_EXPECT(static_cast<bool>(member));
BEAST_EXPECT(member->compare(name) == 0); // NOLINT(bugprone-unchecked-optional-access)
BEAST_EXPECT(*member == name); // NOLINT(bugprone-unchecked-optional-access)
}
// Updating the name (non-empty updates to new non-empty)
@@ -168,8 +168,7 @@ public:
{
auto member = c->member(node);
BEAST_EXPECT(static_cast<bool>(member));
BEAST_EXPECT(
member->compare("test") == 0); // NOLINT(bugprone-unchecked-optional-access)
BEAST_EXPECT(*member == "test"); // NOLINT(bugprone-unchecked-optional-access)
}
}

View File

@@ -858,12 +858,8 @@ public:
bool
isSelected(Peer::id_t id)
{
for (auto& v : validators_)
{
if (overlay_.isSelected(v, id))
return true;
}
return false;
return std::ranges::any_of(
validators_, [&](auto& v) { return overlay_.isSelected(v, id); });
}
/**