mirror of
https://github.com/XRPLF/rippled.git
synced 2026-08-22 23:00:55 +00:00
chore: Enable most readability checks (#7772)
This commit is contained in:
@@ -150,7 +150,7 @@ public:
|
||||
{
|
||||
auto member = c->member(node);
|
||||
BEAST_EXPECT(static_cast<bool>(member));
|
||||
BEAST_EXPECT(member->compare(name) == 0); // NOLINT(bugprone-unchecked-optional-access)
|
||||
BEAST_EXPECT(*member == name); // NOLINT(bugprone-unchecked-optional-access)
|
||||
}
|
||||
|
||||
// Updating the name (non-empty doesn't go to empty)
|
||||
@@ -159,7 +159,7 @@ public:
|
||||
{
|
||||
auto member = c->member(node);
|
||||
BEAST_EXPECT(static_cast<bool>(member));
|
||||
BEAST_EXPECT(member->compare(name) == 0); // NOLINT(bugprone-unchecked-optional-access)
|
||||
BEAST_EXPECT(*member == name); // NOLINT(bugprone-unchecked-optional-access)
|
||||
}
|
||||
|
||||
// Updating the name (non-empty updates to new non-empty)
|
||||
@@ -168,8 +168,7 @@ public:
|
||||
{
|
||||
auto member = c->member(node);
|
||||
BEAST_EXPECT(static_cast<bool>(member));
|
||||
BEAST_EXPECT(
|
||||
member->compare("test") == 0); // NOLINT(bugprone-unchecked-optional-access)
|
||||
BEAST_EXPECT(*member == "test"); // NOLINT(bugprone-unchecked-optional-access)
|
||||
}
|
||||
}
|
||||
|
||||
|
||||
@@ -858,12 +858,8 @@ public:
|
||||
bool
|
||||
isSelected(Peer::id_t id)
|
||||
{
|
||||
for (auto& v : validators_)
|
||||
{
|
||||
if (overlay_.isSelected(v, id))
|
||||
return true;
|
||||
}
|
||||
return false;
|
||||
return std::ranges::any_of(
|
||||
validators_, [&](auto& v) { return overlay_.isSelected(v, id); });
|
||||
}
|
||||
|
||||
/**
|
||||
|
||||
Reference in New Issue
Block a user