ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-04 09:16:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

address review

Browse Source
This commit is contained in:
tequ
2026-02-03 14:45:55 +09:00
parent fe075470f8
commit e1aee43359
1 changed files with 8 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
src/xrpld/app/tx/detail/SponsorshipSet.cpp
View File

@@ -22,26 +22,6 @@ SponsorshipSet::preflight(PreflightContext const& ctx)
if ((flags & tfSponsorshipSetRequireSignForReserve) && (flags & tfSponsorshipClearRequireSignForReserve))
return temINVALID_FLAG;
if (flags & tfDeleteObject)
{
// can not combine with any modification flags when deleting
constexpr std::uint32_t modifyFlags = tfSponsorshipSetRequireSignForFee |
tfSponsorshipSetRequireSignForReserve | tfSponsorshipClearRequireSignForFee |
tfSponsorshipClearRequireSignForReserve;
if (flags & modifyFlags)
return temINVALID_FLAG;
}
else
{
// can not combine set flag with clear flag
if ((flags & tfSponsorshipSetRequireSignForFee) && (flags & tfSponsorshipClearRequireSignForFee))
return temINVALID_FLAG;
if ((flags & tfSponsorshipSetRequireSignForReserve) && (flags & tfSponsorshipClearRequireSignForReserve))
return temINVALID_FLAG;
}
auto const account = ctx.tx.getAccountID(sfAccount);
bool const hasSponsor = ctx.tx.isFieldPresent(sfCounterpartySponsor);
bool const hasSponsee = ctx.tx.isFieldPresent(sfSponsee);
@@ -58,6 +38,14 @@ SponsorshipSet::preflight(PreflightContext const& ctx)
if (flags & tfDeleteObject)
{
// can not combine with any modification flags when deleting
constexpr std::uint32_t modifyFlags = tfSponsorshipSetRequireSignForFee |
tfSponsorshipSetRequireSignForReserve | tfSponsorshipClearRequireSignForFee |
tfSponsorshipClearRequireSignForReserve;
if (flags & modifyFlags)
return temINVALID_FLAG;
// can not include these fields when deleting
if (ctx.tx.isFieldPresent(sfFeeAmount) || ctx.tx.isFieldPresent(sfReserveCount) ||
ctx.tx.isFieldPresent(sfMaxFee))