ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-26 14:05:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Mark some FIXMEs

Browse Source
This commit is contained in:
JoelKatz
2013-07-08 18:48:58 -07:00
parent dcdb15bb11
commit e0e12febce
3 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/cpp/ripple/NetworkOPs.cpp
View File

@@ -1227,6 +1227,10 @@ NetworkOPs::getAccountTxs (const RippleAddress& account, int32 minLedger, int32
} }
else rawMeta.resize (metaSize); else rawMeta.resize (metaSize);
if (rawMeta.getLength() == 0)
{ // FIXME metadata isn't in the table, update metadata and sequence in Transactions DB from ledger
}
TransactionMetaSet::pointer meta = boost::make_shared<TransactionMetaSet> (txn->getID (), txn->getLedger (), rawMeta.getData ()); TransactionMetaSet::pointer meta = boost::make_shared<TransactionMetaSet> (txn->getID (), txn->getLedger (), rawMeta.getData ());
ret.push_back (std::pair<Transaction::pointer, TransactionMetaSet::pointer> (txn, meta)); ret.push_back (std::pair<Transaction::pointer, TransactionMetaSet::pointer> (txn, meta));
} }

2
src/cpp/ripple/Transaction.cpp
View File

@@ -156,6 +156,8 @@ void Transaction::save ()
Database* db = getApp().getTxnDB ()->getDB (); Database* db = getApp().getTxnDB ()->getDB ();
ScopedLock dbLock (getApp().getTxnDB ()->getDBLock ()); ScopedLock dbLock (getApp().getTxnDB ()->getDBLock ());
// FIXME: This can destroy metadata
db->executeSQL (mTransaction->getSQLInsertReplaceHeader () + mTransaction->getSQL (getLedger (), status) + ";"); db->executeSQL (mTransaction->getSQLInsertReplaceHeader () + mTransaction->getSQL (getLedger (), status) + ";");
} }

2
src/cpp/ripple/ripple_AcceptedLedgerTx.cpp
View File

@@ -10,7 +10,7 @@ AcceptedLedgerTx::AcceptedLedgerTx (uint32 seq, SerializerIterator& sit)
SerializerIterator txnIt (txnSer); SerializerIterator txnIt (txnSer);
mTxn = boost::make_shared<SerializedTransaction> (boost::ref (txnIt)); mTxn = boost::make_shared<SerializedTransaction> (boost::ref (txnIt));
mRawMeta = sit.getVL (); mRawMeta = sit.getVL ();
mMeta = boost::make_shared<TransactionMetaSet> (mTxn->getTransactionID (), seq, mRawMeta); mMeta = boost::make_shared<TransactionMetaSet> (mTxn->getTransactionID (), seq, mRawMeta);
mAffected = mMeta->getAffectedAccounts (); mAffected = mMeta->getAffectedAccounts ();
mResult = mMeta->getResultTER (); mResult = mMeta->getResultTER ();