ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Burninate "Value" in "*ValueField*" functions. It was just pointless extra typing.

Browse Source 
What else would you set/get in a field, by name, other than its value?
This commit is contained in:
JoelKatz
2012-10-01 15:35:30 -07:00
parent 18d3773da4
commit e04b695434
22 changed files with 318 additions and 318 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
src/SerializedLedger.cpp
View File

@@ -9,7 +9,7 @@ SerializedLedgerEntry::SerializedLedgerEntry(SerializerIterator& sit, const uint
: STObject(sfLedgerEntry), mIndex(index)
{
set(sit);
uint16 type = getValueFieldU16(sfLedgerEntryType);
uint16 type = getFieldU16(sfLedgerEntryType);
mFormat = getLgrFormat(static_cast<LedgerEntryType>(type));
if (mFormat == NULL)
throw std::runtime_error("invalid ledger entry type");
@@ -24,7 +24,7 @@ SerializedLedgerEntry::SerializedLedgerEntry(const Serializer& s, const uint256&
SerializerIterator sit(s);
set(sit);
uint16 type = getValueFieldU16(sfLedgerEntryType);
uint16 type = getFieldU16(sfLedgerEntryType);
mFormat = getLgrFormat(static_cast<LedgerEntryType>(type));
if (mFormat == NULL)
throw std::runtime_error("invalid ledger entry type");
@@ -42,7 +42,7 @@ SerializedLedgerEntry::SerializedLedgerEntry(LedgerEntryType type) : STObject(sf
mFormat = getLgrFormat(type);
if (mFormat == NULL) throw std::runtime_error("invalid ledger entry type");
set(mFormat->elements);
setValueFieldU16(sfLedgerEntryType, static_cast<uint16>(mFormat->t_type));
setFieldU16(sfLedgerEntryType, static_cast<uint16>(mFormat->t_type));
}
std::string SerializedLedgerEntry::getFullText() const
@@ -85,25 +85,25 @@ bool SerializedLedgerEntry::isThreaded()
uint256 SerializedLedgerEntry::getThreadedTransaction()
{
return getValueFieldH256(sfLastTxnID);
return getFieldH256(sfLastTxnID);
}
uint32 SerializedLedgerEntry::getThreadedLedger()
{
return getValueFieldU32(sfLastTxnSeq);
return getFieldU32(sfLastTxnSeq);
}
bool SerializedLedgerEntry::thread(const uint256& txID, uint32 ledgerSeq, uint256& prevTxID, uint32& prevLedgerID)
{
uint256 oldPrevTxID = getValueFieldH256(sfLastTxnID);
uint256 oldPrevTxID = getFieldH256(sfLastTxnID);
Log(lsTRACE) << "Thread Tx:" << txID << " prev:" << oldPrevTxID;
if (oldPrevTxID == txID)
return false;
prevTxID = oldPrevTxID;
prevLedgerID = getValueFieldU32(sfLastTxnSeq);
prevLedgerID = getFieldU32(sfLastTxnSeq);
assert(prevTxID != txID);
setValueFieldH256(sfLastTxnID, txID);
setValueFieldU32(sfLastTxnSeq, ledgerSeq);
setFieldH256(sfLastTxnID, txID);
setFieldU32(sfLastTxnSeq, ledgerSeq);
return true;
}
@@ -119,17 +119,17 @@ bool SerializedLedgerEntry::hasTwoOwners()
NewcoinAddress SerializedLedgerEntry::getOwner()
{
return getValueFieldAccount(sfAccount);
return getFieldAccount(sfAccount);
}
NewcoinAddress SerializedLedgerEntry::getFirstOwner()
{
return NewcoinAddress::createAccountID(getValueFieldAmount(sfLowLimit).getIssuer());
return NewcoinAddress::createAccountID(getFieldAmount(sfLowLimit).getIssuer());
}
NewcoinAddress SerializedLedgerEntry::getSecondOwner()
{
return NewcoinAddress::createAccountID(getValueFieldAmount(sfHighLimit).getIssuer());
return NewcoinAddress::createAccountID(getFieldAmount(sfHighLimit).getIssuer());
}
std::vector<uint256> SerializedLedgerEntry::getOwners()