Consensus cleanup:

* Inject dependencies, make functions free and levelize
* Add comments to document the intent behind the code
* Reduce class public interfaces
* Remove support for proposals without ledger hashes
This commit is contained in:
Nik Bougalis
2015-05-22 13:08:41 -07:00
committed by Tom Ritchford
parent 1b4e0f5f48
commit dd902292ed
26 changed files with 467 additions and 524 deletions

View File

@@ -57,20 +57,16 @@ STValidation::STValidation (
setFlag (kFullFlag);
}
void STValidation::sign (RippleAddress const& raPriv)
{
uint256 signingHash;
sign (signingHash, raPriv);
}
void STValidation::sign (uint256& signingHash, RippleAddress const& raPriv)
uint256 STValidation::sign (RippleAddress const& raPriv)
{
setFlag (vfFullyCanonicalSig);
signingHash = getSigningHash ();
auto signingHash = getSigningHash ();
Blob signature;
raPriv.signNodePrivate (signingHash, signature);
setFieldVL (sfSignature, signature);
return signingHash;
}
uint256 STValidation::getSigningHash () const