ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Provide sensible default values for nodestore cache:

Browse Source 
The nodestore includes a built-in cache to reduce the disk I/O
load but, by default, this cache was not initialized unless it
was explicitly configured by the server operator.

This commit introduces sensible defaults based on the server's
configured node size.

It remains possible to completely disable the cache if desired
by explicitly configuring it the cache size and age parameters
to 0:

    [node_db]
    ...
    cache_size = 0
    cache_age = 0
This commit is contained in:
Nik Bougalis
2021-12-19 23:57:45 -08:00
parent 18584ef2fd
commit dc778536ed
3 changed files with 48 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

35
src/ripple/nodestore/impl/DatabaseNodeImp.cpp
View File

@@ -31,9 +31,9 @@ DatabaseNodeImp::store(
uint256 const& hash,
std::uint32_t)
{
auto nObj = NodeObject::createObject(type, std::move(data), hash);
backend_->store(nObj);
storeStats(1, nObj->getData().size());
storeStats(1, data.size());
backend_->store(NodeObject::createObject(type, std::move(data), hash));
}
void
@@ -50,12 +50,14 @@ DatabaseNodeImp::fetchNodeObject(
FetchReport& fetchReport,
bool duplicate)
{
std::shared_ptr<NodeObject> nodeObject{
cache_ ? cache_->fetch(hash) : nullptr};
std::shared_ptr<NodeObject> nodeObject =
cache_ ? cache_->fetch(hash) : nullptr;
if (!nodeObject)
{
JLOG(j_.trace())
<< "DatabaseNodeImp::fetchNodeObject - record not in cache";
JLOG(j_.trace()) << "fetchNodeObject " << hash << ": record not "
<< (cache_ ? "cached" : "found");
Status status;
try
@@ -64,7 +66,9 @@ DatabaseNodeImp::fetchNodeObject(
}
catch (std::exception const& e)
{
JLOG(j_.fatal()) << "Exception, " << e.what();
JLOG(j_.fatal())
<< "fetchNodeObject " << hash
<< ": Exception fetching from backend: " << e.what();
Rethrow();
}
@@ -77,17 +81,20 @@ DatabaseNodeImp::fetchNodeObject(
case notFound:
break;
case dataCorrupt:
JLOG(j_.fatal()) << "Corrupt NodeObject #" << hash;
JLOG(j_.fatal()) << "fetchNodeObject " << hash
<< ": nodestore data is corrupted";
break;
default:
JLOG(j_.warn()) << "Unknown status=" << status;
JLOG(j_.warn())
<< "fetchNodeObject " << hash
<< ": backend returns unknown result " << status;
break;
}
}
else
{
JLOG(j_.trace())
<< "DatabaseNodeImp::fetchNodeObject - record in cache";
JLOG(j_.trace()) << "fetchNodeObject " << hash
<< ": record found in cache";
}
if (nodeObject)
@@ -126,7 +133,7 @@ DatabaseNodeImp::fetchBatch(std::vector<uint256> const& hashes)
}
}
JLOG(j_.debug()) << "DatabaseNodeImp::fetchBatch - cache hits = "
JLOG(j_.debug()) << "fetchBatch - cache hits = "
<< (hashes.size() - cacheMisses.size())
<< " - cache misses = " << cacheMisses.size();
auto dbResults = backend_->fetchBatch(cacheMisses).first;
@@ -147,7 +154,7 @@ DatabaseNodeImp::fetchBatch(std::vector<uint256> const& hashes)
else
{
JLOG(j_.error())
<< "DatabaseNodeImp::fetchBatch - "
<< "fetchBatch - "
<< "record not found in db or cache. hash = " << strHex(hash);
}
}