fix clang-tidy

2026-10-10 05:38:10 +00:00 · 2026-08-11 14:29:56 -04:00
parent 3ff036dc4c
commit dc75de050d
34 changed files with 33 additions and 53 deletions
--- a/include/xrpl/ledger/helpers/AMMEntry.h
+++ b/include/xrpl/ledger/helpers/AMMEntry.h
@@ -1,12 +1,12 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/Asset.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/AccountRootEntry.h
+++ b/include/xrpl/ledger/helpers/AccountRootEntry.h
@@ -6,6 +6,7 @@
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/AmendmentsEntry.h
+++ b/include/xrpl/ledger/helpers/AmendmentsEntry.h
@@ -5,6 +5,7 @@
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/BridgeEntry.h
+++ b/include/xrpl/ledger/helpers/BridgeEntry.h
@@ -5,6 +5,7 @@
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/STXChainBridge.h>

 namespace xrpl {
--- a/include/xrpl/ledger/helpers/CheckEntry.h
+++ b/include/xrpl/ledger/helpers/CheckEntry.h
@@ -1,12 +1,12 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 #include <cstdint>

--- a/include/xrpl/ledger/helpers/CredentialEntry.h
+++ b/include/xrpl/ledger/helpers/CredentialEntry.h
@@ -1,13 +1,13 @@
 #pragma once

 #include <xrpl/basics/Slice.h>
-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/CredentialHelpers.h
+++ b/include/xrpl/ledger/helpers/CredentialHelpers.h
@@ -1,8 +1,5 @@
 #pragma once

-#include <xrpl/basics/Slice.h>
-#include <xrpl/basics/base_uint.h>
-#include <xrpl/basics/chrono.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
@@ -11,11 +8,8 @@
 #include <xrpl/protocol/STLedgerEntry.h>
 #include <xrpl/protocol/STTx.h>
 #include <xrpl/protocol/STVector256.h>
-#include <xrpl/protocol/TER.h>

 #include <memory>
-#include <set>
-#include <utility>

 namespace xrpl {
 namespace credentials {
--- a/include/xrpl/ledger/helpers/DIDEntry.h
+++ b/include/xrpl/ledger/helpers/DIDEntry.h
@@ -6,6 +6,7 @@
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/DelegateEntry.h
+++ b/include/xrpl/ledger/helpers/DelegateEntry.h
@@ -6,6 +6,7 @@
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/DepositPreauthEntry.h
+++ b/include/xrpl/ledger/helpers/DepositPreauthEntry.h
@@ -1,16 +1,12 @@
 #pragma once

-#include <xrpl/basics/Slice.h>
-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
-
-#include <set>
-#include <utility>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/DirectoryNodeEntry.h
+++ b/include/xrpl/ledger/helpers/DirectoryNodeEntry.h
@@ -1,14 +1,12 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
-
-#include <cstdint>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/EscrowEntry.h
+++ b/include/xrpl/ledger/helpers/EscrowEntry.h
@@ -6,8 +6,7 @@
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
-
-#include <cstdint>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/EscrowHelpers.h
+++ b/include/xrpl/ledger/helpers/EscrowHelpers.h
@@ -4,17 +4,12 @@
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/helpers/AccountRootHelpers.h>
-#include <xrpl/ledger/helpers/MPTokenHelpers.h>
-#include <xrpl/ledger/helpers/RippleStateHelpers.h>
-#include <xrpl/ledger/helpers/SponsorHelpers.h>
 #include <xrpl/ledger/helpers/TokenHelpers.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Concepts.h>
-#include <xrpl/protocol/Feature.h>
 #include <xrpl/protocol/Indexes.h>
 #include <xrpl/protocol/Issue.h>
 #include <xrpl/protocol/Keylet.h>
-#include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/MPTIssue.h>
 #include <xrpl/protocol/Rate.h>
 #include <xrpl/protocol/SField.h>
--- a/include/xrpl/ledger/helpers/FeeSettingsEntry.h
+++ b/include/xrpl/ledger/helpers/FeeSettingsEntry.h
@@ -5,6 +5,7 @@
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/LedgerHashesEntry.h
+++ b/include/xrpl/ledger/helpers/LedgerHashesEntry.h
@@ -5,6 +5,7 @@
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/LoanBrokerEntry.h
+++ b/include/xrpl/ledger/helpers/LoanBrokerEntry.h
@@ -1,12 +1,12 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 #include <cstdint>

--- a/include/xrpl/ledger/helpers/LoanEntry.h
+++ b/include/xrpl/ledger/helpers/LoanEntry.h
@@ -1,11 +1,10 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
-#include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 #include <cstdint>

--- a/include/xrpl/ledger/helpers/MPTokenEntry.h
+++ b/include/xrpl/ledger/helpers/MPTokenEntry.h
@@ -1,13 +1,11 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
-#include <xrpl/protocol/Indexes.h>
-#include <xrpl/protocol/UintTypes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/MPTokenIssuanceEntry.h
+++ b/include/xrpl/ledger/helpers/MPTokenIssuanceEntry.h
@@ -1,13 +1,12 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
-#include <xrpl/protocol/UintTypes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 #include <cstdint>

--- a/include/xrpl/ledger/helpers/NFTokenOfferEntry.h
+++ b/include/xrpl/ledger/helpers/NFTokenOfferEntry.h
@@ -1,12 +1,12 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 #include <cstdint>

--- a/include/xrpl/ledger/helpers/NFTokenPageEntry.h
+++ b/include/xrpl/ledger/helpers/NFTokenPageEntry.h
@@ -1,12 +1,11 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
-#include <xrpl/protocol/Indexes.h>
 #include <xrpl/protocol/Keylet.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/NegativeUNLEntry.h
+++ b/include/xrpl/ledger/helpers/NegativeUNLEntry.h
@@ -5,6 +5,7 @@
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/OfferEntry.h
+++ b/include/xrpl/ledger/helpers/OfferEntry.h
@@ -1,12 +1,12 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 #include <cstdint>

--- a/include/xrpl/ledger/helpers/OracleEntry.h
+++ b/include/xrpl/ledger/helpers/OracleEntry.h
@@ -6,8 +6,7 @@
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
-
-#include <cstdint>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/PayChannelEntry.h
+++ b/include/xrpl/ledger/helpers/PayChannelEntry.h
@@ -6,8 +6,7 @@
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
-
-#include <cstdint>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/PermissionedDomainEntry.h
+++ b/include/xrpl/ledger/helpers/PermissionedDomainEntry.h
@@ -1,12 +1,12 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 #include <cstdint>

--- a/include/xrpl/ledger/helpers/RippleStateEntry.h
+++ b/include/xrpl/ledger/helpers/RippleStateEntry.h
@@ -7,6 +7,7 @@
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
 #include <xrpl/protocol/Issue.h>
+#include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/UintTypes.h>

 namespace xrpl {
--- a/include/xrpl/ledger/helpers/SLEBase.h
+++ b/include/xrpl/ledger/helpers/SLEBase.h
@@ -1,6 +1,5 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/beast/utility/instrumentation.h>
 #include <xrpl/ledger/ApplyView.h>
@@ -10,9 +9,6 @@
 #include <xrpl/protocol/STLedgerEntry.h>

 #include <concepts>
-#include <memory>
-#include <type_traits>
-#include <utility>

 namespace xrpl {

@@ -426,7 +422,7 @@ public:
    }

 protected:
-    view_ref_type view_;
+    view_ref_type view_{} {};

    // Keylet is only meaningful for writable views, which need it to build an
    // SLE that does not exist yet; read-only wrappers derive it from the entry.
@@ -436,7 +432,7 @@ protected:
    // No default member initializer: Keylet is not default-constructible, so
    // every writable constructor must initialize key_ explicitly.
    [[no_unique_address]]
-    std::conditional_t<kIsWritable, Keylet, Empty> key_;
+    std::conditional_t<kIsWritable, Keylet, Empty> key_{} {};

    sle_ptr_type sle_{};
    beast::Journal j_;
--- a/include/xrpl/ledger/helpers/SignerListEntry.h
+++ b/include/xrpl/ledger/helpers/SignerListEntry.h
@@ -6,6 +6,7 @@
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/SponsorshipEntry.h
+++ b/include/xrpl/ledger/helpers/SponsorshipEntry.h
@@ -6,6 +6,7 @@
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 namespace xrpl {

--- a/include/xrpl/ledger/helpers/TicketEntry.h
+++ b/include/xrpl/ledger/helpers/TicketEntry.h
@@ -1,12 +1,12 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/SeqProxy.h>

 #include <cstdint>
--- a/include/xrpl/ledger/helpers/VaultEntry.h
+++ b/include/xrpl/ledger/helpers/VaultEntry.h
@@ -1,12 +1,12 @@
 #pragma once

-#include <xrpl/basics/base_uint.h>
 #include <xrpl/beast/utility/Journal.h>
 #include <xrpl/ledger/ApplyView.h>
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/AccountID.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>

 #include <cstdint>

--- a/include/xrpl/ledger/helpers/XChainOwnedClaimIDEntry.h
+++ b/include/xrpl/ledger/helpers/XChainOwnedClaimIDEntry.h
@@ -5,10 +5,9 @@
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/STXChainBridge.h>

-#include <cstdint>
-
 namespace xrpl {

 template <typename ViewT>
--- a/include/xrpl/ledger/helpers/XChainOwnedCreateAccountClaimIDEntry.h
+++ b/include/xrpl/ledger/helpers/XChainOwnedCreateAccountClaimIDEntry.h
@@ -5,10 +5,9 @@
 #include <xrpl/ledger/ReadView.h>
 #include <xrpl/ledger/helpers/SLEBase.h>
 #include <xrpl/protocol/Indexes.h>
+#include <xrpl/protocol/LedgerFormats.h>
 #include <xrpl/protocol/STXChainBridge.h>

-#include <cstdint>
-
 namespace xrpl {

 template <typename ViewT>