From db38ba268feb4da2beb8c4ad5a232ebe3a5f5e10 Mon Sep 17 00:00:00 2001
From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Date: Wed, 8 Jul 2026 15:18:55 +0100
Subject: [PATCH] fix(telemetry): use std::ranges algorithms
 (modernize-use-ranges)

Replace std::transform with std::ranges::transform in Redaction.cpp.
Replace std::all_of with std::ranges::all_of in Redaction test.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
---
 src/libxrpl/telemetry/Redaction.cpp       | 6 +++---
 src/tests/libxrpl/telemetry/Redaction.cpp | 3 ++-
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/libxrpl/telemetry/Redaction.cpp b/src/libxrpl/telemetry/Redaction.cpp
index ee15b8812e..d6bfe52ec3 100644
--- a/src/libxrpl/telemetry/Redaction.cpp
+++ b/src/libxrpl/telemetry/Redaction.cpp
@@ -6,6 +6,7 @@
 
 #include <algorithm>
 #include <cctype>
+#include <ranges>
 #include <string>
 #include <string_view>
 
@@ -23,9 +24,8 @@ redactAccount(std::string_view addr)
     // staying non-reversible — and lowercase them for a stable token.
     auto const digest = sha512Half(Slice(addr.data(), addr.size()));
     std::string token = to_string(digest).substr(0, 16);
-    std::transform(token.begin(), token.end(), token.begin(), [](unsigned char c) {
-        return static_cast<char>(std::tolower(c));
-    });
+    std::ranges::transform(
+        token, token.begin(), [](unsigned char c) { return static_cast<char>(std::tolower(c)); });
     return token;
 }
 
diff --git a/src/tests/libxrpl/telemetry/Redaction.cpp b/src/tests/libxrpl/telemetry/Redaction.cpp
index 7f16c0f1dc..db1cc95135 100644
--- a/src/tests/libxrpl/telemetry/Redaction.cpp
+++ b/src/tests/libxrpl/telemetry/Redaction.cpp
@@ -4,6 +4,7 @@
 
 #include <algorithm>
 #include <cctype>
+#include <ranges>
 #include <string>
 
 using namespace xrpl;
@@ -28,7 +29,7 @@ TEST(Redaction, token_is_16_lowercase_hex_and_stable)
 {
     auto const token = redactAccount("rHb9CJAWyB4rj91VRWn96DkukG4bwdtyTh");
     EXPECT_EQ(token.size(), 16u);
-    EXPECT_TRUE(std::all_of(token.begin(), token.end(), [](unsigned char c) {
+    EXPECT_TRUE(std::ranges::all_of(token, [](unsigned char c) {
         return std::isdigit(c) || (c >= 'a' && c <= 'f');
     }));
     // Deterministic: hashing the same input twice yields the same token.