From dae0943dc3d822ed0743ebc3e660b919d3db6a8d Mon Sep 17 00:00:00 2001 From: Ed Hennis Date: Tue, 12 May 2026 16:57:01 -0400 Subject: [PATCH] Fix a couple of bugs introduced by the previous merge --- src/libxrpl/basics/Number.cpp | 5 ++++- src/test/basics/Number_test.cpp | 3 --- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libxrpl/basics/Number.cpp b/src/libxrpl/basics/Number.cpp index d3ce45b3bf..157a2ee476 100644 --- a/src/libxrpl/basics/Number.cpp +++ b/src/libxrpl/basics/Number.cpp @@ -615,7 +615,10 @@ Number::fromInternal(bool negative, Rep mantissa, int exponent) Number Number::one(MantissaRange const& range) { - return Number{false, range.min, -range.log, Number::Unchecked{}}; + XRPL_ASSERT(isPowerOfTen(range.internalMin), "Number::one : valid range internalMin"); + auto const result = Number{false, range.internalMin, -range.log, Number::Unchecked{}}; + XRPL_ASSERT(result == 1, "Number::one : One == 1"); + return result; } Number diff --git a/src/test/basics/Number_test.cpp b/src/test/basics/Number_test.cpp index 159f47360e..83ba487eb6 100644 --- a/src/test/basics/Number_test.cpp +++ b/src/test/basics/Number_test.cpp @@ -200,9 +200,6 @@ public: {Number{true, 9'999'999'999'999'999'999ULL, -37, Number::Normalized{}}, Number{1'000'000'000'000'000'000, -18}, Number{false, 9'999'999'999'999'999'990ULL, -19, Number::Normalized{}}}, - {Number{Number::kLARGEST_MANTISSA}, - Number{6, -1}, - Number{Number::kLARGEST_MANTISSA / 10, 1}}, {Number{Number::kLARGEST_MANTISSA - 1}, Number{1, 0}, Number{Number::kLARGEST_MANTISSA}},