From d94e4c2491187f377606d4a906de608b487facf9 Mon Sep 17 00:00:00 2001 From: Vinnie Falco Date: Tue, 17 Sep 2013 17:32:04 -0700 Subject: [PATCH] Fix undefined behavior in UnsignedIntegerCalc (again) --- modules/beast_crypto/math/UnsignedIntegerCalc.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/modules/beast_crypto/math/UnsignedIntegerCalc.h b/modules/beast_crypto/math/UnsignedIntegerCalc.h index e714c0895b..5bb7f0f4f6 100644 --- a/modules/beast_crypto/math/UnsignedIntegerCalc.h +++ b/modules/beast_crypto/math/UnsignedIntegerCalc.h @@ -115,8 +115,10 @@ public: while (lo < hi) { std::swap (*lo, *hi); - *lo++ = fromNetworkByteOrder (*lo); - *hi-- = fromNetworkByteOrder (*hi); + *lo = fromNetworkByteOrder (*lo); + ++lo; + *hi = fromNetworkByteOrder (*hi); + ++hi; } if (lo == hi) *lo = fromNetworkByteOrder (*lo);