Handle websocket construction exceptions:

Certain versions of the Beast HTTP & WebSocket library can
generate exceptions, which unless caught, will result in
unexpected behavior.

Acknowledgements:
Ripple thanks Thomas Snider for originally noticing this
issue and responsibly disclosing it to Ripple.

Bug Bounties and Responsible Disclosures:
We welcome reviews of the rippled code and urge researchers
to responsibly disclose any issues that they may find. For
more on Ripple's Bug Bounty program, please visit:
https://ripple.com/bug-bounty
This commit is contained in:
Miguel Portilla
2018-07-05 20:35:57 -04:00
committed by Nik Bougalis
parent d289512aeb
commit d89ff1b63d
4 changed files with 62 additions and 80 deletions

View File

@@ -111,9 +111,8 @@ public:
}
Handoff
onHandoff (Session& session, boost::asio::ip::tcp::socket&& socket,
http_request_type&& request,
boost::asio::ip::tcp::endpoint remote_address)
onHandoff (Session& session, http_request_type&& request,
boost::asio::ip::tcp::endpoint remote_address)
{
return Handoff{};
}
@@ -317,9 +316,8 @@ public:
}
Handoff
onHandoff (Session& session, boost::asio::ip::tcp::socket&& socket,
http_request_type&& request,
boost::asio::ip::tcp::endpoint remote_address)
onHandoff (Session& session, http_request_type&& request,
boost::asio::ip::tcp::endpoint remote_address)
{
return Handoff{};
}