From ea0bd444c86d69c3470cbd1037de1b09f8c147c3 Mon Sep 17 00:00:00 2001
From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com>
Date: Tue, 15 Sep 2026 11:38:26 +0100
Subject: [PATCH] fix(test): clear clang-tidy include-cleaner and nodiscard
 findings

OTelCollectorHooks.cpp named nothing from Hook.h, took ResourceMetrics
without a direct include, and left the overriding
GetAggregationTemporality() unmarked. NodeIdentity.h carried <optional>
and <string> it no longer uses. All fail CI under warnings-as-errors.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
---
 src/tests/libxrpl/beast/insight/OTelCollectorHooks.cpp | 4 ++--
 src/xrpld/app/main/NodeIdentity.h                      | 2 --
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/src/tests/libxrpl/beast/insight/OTelCollectorHooks.cpp b/src/tests/libxrpl/beast/insight/OTelCollectorHooks.cpp
index 18f35e2f8a..2964b3ebe9 100644
--- a/src/tests/libxrpl/beast/insight/OTelCollectorHooks.cpp
+++ b/src/tests/libxrpl/beast/insight/OTelCollectorHooks.cpp
@@ -2,7 +2,6 @@
 
 #include <xrpl/beast/insight/Collector.h>
 #include <xrpl/beast/insight/Gauge.h>
-#include <xrpl/beast/insight/Hook.h>
 #include <xrpl/beast/insight/OTelCollector.h>
 #include <xrpl/beast/utility/Journal.h>
 
@@ -11,6 +10,7 @@
 #include <opentelemetry/metrics/provider.h>
 #include <opentelemetry/nostd/function_ref.h>
 #include <opentelemetry/nostd/shared_ptr.h>
+#include <opentelemetry/sdk/metrics/export/metric_producer.h>
 #include <opentelemetry/sdk/metrics/instruments.h>
 #include <opentelemetry/sdk/metrics/meter_provider.h>
 #include <opentelemetry/sdk/metrics/meter_provider_factory.h>
@@ -57,7 +57,7 @@ public:
         Collect([](metrics_sdk::ResourceMetrics&) { return true; });
     }
 
-    metrics_sdk::AggregationTemporality
+    [[nodiscard]] metrics_sdk::AggregationTemporality
     GetAggregationTemporality(metrics_sdk::InstrumentType) const noexcept override
     {
         return metrics_sdk::AggregationTemporality::kCumulative;
diff --git a/src/xrpld/app/main/NodeIdentity.h b/src/xrpld/app/main/NodeIdentity.h
index 837d07184b..5f777133bb 100644
--- a/src/xrpld/app/main/NodeIdentity.h
+++ b/src/xrpld/app/main/NodeIdentity.h
@@ -9,8 +9,6 @@
 
 #include <boost/program_options.hpp>
 
-#include <optional>
-#include <string>
 #include <utility>
 
 namespace xrpl {