From d6757ce1a5deea2c0f13295e5bf8641e70bce1fd Mon Sep 17 00:00:00 2001 From: TimothyBanks Date: Thu, 10 Sep 2026 13:07:34 -0400 Subject: [PATCH] chore: Address code review comments --- src/tests/libxrpl/tx/wasm/transactor/BytecodeRun.cpp | 3 +-- src/tests/libxrpl/tx/wasm/transactor/DataOnReject.cpp | 1 + src/tests/libxrpl/tx/wasm/transactor/FinishFailures.cpp | 3 +-- src/tests/libxrpl/tx/wasm/transactor/GasFees.cpp | 1 + 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/tests/libxrpl/tx/wasm/transactor/BytecodeRun.cpp b/src/tests/libxrpl/tx/wasm/transactor/BytecodeRun.cpp index ac9c2254b0..d58d20aaac 100644 --- a/src/tests/libxrpl/tx/wasm/transactor/BytecodeRun.cpp +++ b/src/tests/libxrpl/tx/wasm/transactor/BytecodeRun.cpp @@ -41,8 +41,7 @@ struct BytecodeRun : testing::Test Account const alice{"alice"}; Account const carol{"carol"}; - void - SetUp() override + BytecodeRun() { createAccounts(env, XRP(5'000), alice, carol); } diff --git a/src/tests/libxrpl/tx/wasm/transactor/DataOnReject.cpp b/src/tests/libxrpl/tx/wasm/transactor/DataOnReject.cpp index fc6a18d8ae..b2ecb6298d 100644 --- a/src/tests/libxrpl/tx/wasm/transactor/DataOnReject.cpp +++ b/src/tests/libxrpl/tx/wasm/transactor/DataOnReject.cpp @@ -49,6 +49,7 @@ struct DataOnReject : testing::Test void SetUp() override { + testing::Test::SetUp(); env.createAccount(alice, XRP(5'000)); auto const wasm = assembleWat(kWritesThenRejects); diff --git a/src/tests/libxrpl/tx/wasm/transactor/FinishFailures.cpp b/src/tests/libxrpl/tx/wasm/transactor/FinishFailures.cpp index dce08ba985..f9b06d426b 100644 --- a/src/tests/libxrpl/tx/wasm/transactor/FinishFailures.cpp +++ b/src/tests/libxrpl/tx/wasm/transactor/FinishFailures.cpp @@ -31,8 +31,7 @@ struct FinishFailures : testing::Test Account const alice{"alice"}; Account const carol{"carol"}; - void - SetUp() override + FinishFailures() { createAccounts(env, XRP(5'000), alice, carol); } diff --git a/src/tests/libxrpl/tx/wasm/transactor/GasFees.cpp b/src/tests/libxrpl/tx/wasm/transactor/GasFees.cpp index 0e8253b7cf..1fa5a329a4 100644 --- a/src/tests/libxrpl/tx/wasm/transactor/GasFees.cpp +++ b/src/tests/libxrpl/tx/wasm/transactor/GasFees.cpp @@ -33,6 +33,7 @@ struct GasFees : testing::Test void SetUp() override { + testing::Test::SetUp(); createAccounts(env, XRP(5'000), alice, carol); auto const wasm = assembleWat(kReadsLedgerSqn);