ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-26 14:05:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Report a rate of zero for worthless orders.

Browse Source
This commit is contained in:
JoelKatz
2013-01-30 11:29:59 -08:00
parent 3b338b8825
commit d663037ddc
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
src/cpp/ripple/Amount.cpp
View File

@@ -995,11 +995,15 @@ STAmount STAmount::multiply(const STAmount& v1, const STAmount& v2, const uint16
// <-- uRate: normalize(offerIn/offerOut) // <-- uRate: normalize(offerIn/offerOut)
// A lower rate is better for the person taking the order. // A lower rate is better for the person taking the order.
// The taker gets more for less with a lower rate. // The taker gets more for less with a lower rate.
// Zero is returned if the offer is worthless.
uint64 STAmount::getRate(const STAmount& offerOut, const STAmount& offerIn) uint64 STAmount::getRate(const STAmount& offerOut, const STAmount& offerIn)
{ {
if (offerOut.isZero()) throw std::runtime_error("Worthless offer"); if (offerOut.isZero())
return 0;
STAmount r = divide(offerIn, offerOut, CURRENCY_ONE, ACCOUNT_ONE); STAmount r = divide(offerIn, offerOut, CURRENCY_ONE, ACCOUNT_ONE);
if (r.isZero())
return 0;
assert((r.getExponent() >= -100) && (r.getExponent() <= 155)); assert((r.getExponent() >= -100) && (r.getExponent() <= 155));
@@ -1010,6 +1014,9 @@ uint64 STAmount::getRate(const STAmount& offerOut, const STAmount& offerIn)
STAmount STAmount::setRate(uint64 rate) STAmount STAmount::setRate(uint64 rate)
{ {
if (rate == 0)
return STAmount(CURRENCY_ONE, ACCOUNT_ONE);
uint64 mantissa = rate & ~(255ull << (64 - 8)); uint64 mantissa = rate & ~(255ull << (64 - 8));
int exponent = static_cast<int>(rate >> (64 - 8)) - 100; int exponent = static_cast<int>(rate >> (64 - 8)) - 100;