From d6565f0e4d6e99822c497c3d5b81f54aa6c09ef8 Mon Sep 17 00:00:00 2001
From: Vito <5780819+Tapanito@users.noreply.github.com>
Date: Mon, 10 Aug 2026 13:29:19 +0200
Subject: [PATCH] fix: Silence -Wunused-variable on the asset asserts

Mark the `Asset const asset` local in addVaultAssets and removeVaultAssets
as [[maybe_unused]]: it is only referenced from XRPL_ASSERT, which is
compiled out in Release (NDEBUG) builds, so clang's -Werror,
-Wunused-variable was breaking the ubuntu-clang-release-amd64 CI job.
The moveVaultAssets copy is used in real code paths and is unaffected.
---
 src/libxrpl/ledger/helpers/VaultHelpers.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/libxrpl/ledger/helpers/VaultHelpers.cpp b/src/libxrpl/ledger/helpers/VaultHelpers.cpp
index c66c06f24d..769e50149b 100644
--- a/src/libxrpl/ledger/helpers/VaultHelpers.cpp
+++ b/src/libxrpl/ledger/helpers/VaultHelpers.cpp
@@ -185,7 +185,7 @@ addVaultAssets(
 {
     XRPL_ASSERT(vault && vault->getType() == ltVAULT, "xrpl::addVaultAssets : valid Vault sle");
 
-    Asset const asset = vault->at(sfAsset);
+    [[maybe_unused]] Asset const asset = vault->at(sfAsset);
     XRPL_ASSERT(amount.asset() == asset, "xrpl::addVaultAssets : amount matches vault asset");
     XRPL_ASSERT(
         valueDelta.asset() == asset, "xrpl::addVaultAssets : valueDelta matches vault asset");
@@ -300,7 +300,7 @@ removeVaultAssets(
 {
     XRPL_ASSERT(vault && vault->getType() == ltVAULT, "xrpl::removeVaultAssets : valid Vault sle");
 
-    Asset const asset = vault->at(sfAsset);
+    [[maybe_unused]] Asset const asset = vault->at(sfAsset);
     XRPL_ASSERT(amount.asset() == asset, "xrpl::removeVaultAssets : amount matches vault asset");
     XRPL_ASSERT(amount >= beast::kZero, "xrpl::removeVaultAssets : amount is non-negative");