From d616aff4e2357be92ff1db11063c02dc123a8aca Mon Sep 17 00:00:00 2001 From: Mayukha Vadari Date: Thu, 9 Apr 2026 17:14:46 -0400 Subject: [PATCH] fix tests (typos) --- src/libxrpl/ledger/helpers/AMMHelpers.cpp | 2 +- src/libxrpl/tx/transactors/check/CheckCash.cpp | 2 +- src/libxrpl/tx/transactors/dex/OfferCreate.cpp | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/libxrpl/ledger/helpers/AMMHelpers.cpp b/src/libxrpl/ledger/helpers/AMMHelpers.cpp index e0b4aa6d03..9ea6a14ad0 100644 --- a/src/libxrpl/ledger/helpers/AMMHelpers.cpp +++ b/src/libxrpl/ledger/helpers/AMMHelpers.cpp @@ -704,7 +704,7 @@ deleteAMMAccount(Sandbox& sb, Asset const& asset, Asset const& asset2, beast::Jo return ter; auto const ownerDirKeylet = keylet::ownerDir(ammAccountID); - if (!sb.dirRemove(ownerDirKeylet, (*ammRoot)[sfOwnerNode], ammRoot->key(), false)) + if (!sb.dirRemove(ownerDirKeylet, (*ammSle)[sfOwnerNode], ammSle->key(), false)) { // LCOV_EXCL_START JLOG(j.error()) << "deleteAMMAccount: failed to remove dir link"; diff --git a/src/libxrpl/tx/transactors/check/CheckCash.cpp b/src/libxrpl/tx/transactors/check/CheckCash.cpp index a4fe53f202..caf3824256 100644 --- a/src/libxrpl/tx/transactors/check/CheckCash.cpp +++ b/src/libxrpl/tx/transactors/check/CheckCash.cpp @@ -402,7 +402,7 @@ CheckCash::doApply() // b. issuing account (not sending account). auto dstOpt = checkReserve(); - if (dstOpt) + if (!dstOpt) return tecNO_LINE_INSUF_RESERVE; auto& dst = *dstOpt; diff --git a/src/libxrpl/tx/transactors/dex/OfferCreate.cpp b/src/libxrpl/tx/transactors/dex/OfferCreate.cpp index 0ba94acad4..6f95226e3f 100644 --- a/src/libxrpl/tx/transactors/dex/OfferCreate.cpp +++ b/src/libxrpl/tx/transactors/dex/OfferCreate.cpp @@ -7,6 +7,7 @@ #include #include #include +#include #include #include #include @@ -319,8 +320,7 @@ OfferCreate::flowCross( STAmount sendMax = takerAmount.in; if (!sendMax.native() && (accountID_ != sendMax.getIssuer())) { - WAccountRoot const wrappedAcct(sendMax.getIssuer(), psb, j_); - gatewayXferRate = wrappedAcct.transferRate(); + gatewayXferRate = transferRate(psb, sendMax); if (gatewayXferRate.value != QUALITY_ONE) { sendMax =