mirror of
https://github.com/XRPLF/rippled.git
synced 2025-12-06 17:27:55 +00:00
Address issues identified by external review:
* RIPD-1617, RIPD-1619, RIPD-1621:
Verify serialized public keys more strictly before
using them.
* RIPD-1618:
* Simplify the base58 decoder logic.
* Reduce the complexity of the base58 encoder and
eliminate a potential out-of-bounds memory access.
* Improve type safety by using an `enum class` to
enforce strict type checking for token types.
* RIPD-1616:
Avoid calling `memcpy` with a null pointer even if the
size is specified as zero, since it results in undefined
behavior.
Acknowledgements:
Ripple thanks Guido Vranken for responsibly disclosing these
issues.
Bug Bounties and Responsible Disclosures:
We welcome reviews of the rippled code and urge researchers
to responsibly disclose any issues that they may find. For
more on Ripple's Bug Bounty program, please visit:
https://ripple.com/bug-bounty
This commit is contained in:
@@ -69,7 +69,7 @@ class AccountCurrencies_test : public beast::unit_test::suite
|
||||
{ // strict mode, using properly formatted bitcoin token
|
||||
Json::Value params;
|
||||
params[jss::account] = base58EncodeTokenBitcoin (
|
||||
TOKEN_ACCOUNT_ID, alice.id().data(), alice.id().size());
|
||||
TokenType::AccountID, alice.id().data(), alice.id().size());
|
||||
params[jss::strict] = true;
|
||||
auto const result = env.rpc ("json", "account_currencies",
|
||||
boost::lexical_cast<std::string>(params)) [jss::result];
|
||||
|
||||
Reference in New Issue
Block a user