diff --git a/.cspell.config.yaml b/.cspell.config.yaml index 7cdee0c2bf..a5a1e6249a 100644 --- a/.cspell.config.yaml +++ b/.cspell.config.yaml @@ -181,6 +181,7 @@ words: - lsmf - ltype - mathbunnyru + - maxima - mcmodel - MEMORYSTATUSEX - MPTAMM @@ -200,6 +201,7 @@ words: - mptokenissuance - mptokens - mpts + - mpt - mtgox - multisig - multisign @@ -390,6 +392,7 @@ words: - ximinez - XMACRO - xored + - xrp - xrpkuwait - xrpl - xrpld diff --git a/src/tests/libxrpl/tx/wasm/host_context/FloatFromSTAmount.cpp b/src/tests/libxrpl/tx/wasm/host_context/FloatFromSTAmount.cpp index ba2b7fc704..92067233c6 100644 --- a/src/tests/libxrpl/tx/wasm/host_context/FloatFromSTAmount.cpp +++ b/src/tests/libxrpl/tx/wasm/host_context/FloatFromSTAmount.cpp @@ -137,7 +137,7 @@ struct FloatFromSTAmountBounds : HostContextTest } }; -TEST_F(FloatFromSTAmountBounds, AnMptMagnitudeAtTheSignBitIsRefused) +TEST_F(FloatFromSTAmountBounds, an_mpt_magnitude_at_the_sign_bit_is_refused) { EXPECT_CALL(host, floatFromSTAmount).Times(0); @@ -148,7 +148,7 @@ TEST_F(FloatFromSTAmountBounds, AnMptMagnitudeAtTheSignBitIsRefused) hfErrorToInt(HostFunctionError::InvalidParams)); } -TEST_F(FloatFromSTAmountBounds, AnMptMagnitudePastTheProtocolMaximumIsRefused) +TEST_F(FloatFromSTAmountBounds, an_mpt_magnitude_past_the_protocol_maximum_is_refused) { EXPECT_CALL(host, floatFromSTAmount).Times(0); @@ -160,7 +160,7 @@ TEST_F(FloatFromSTAmountBounds, AnMptMagnitudePastTheProtocolMaximumIsRefused) } // MPT amounts are non-negative by protocol invariant, which is why `isLegalMPT` asks. -TEST_F(FloatFromSTAmountBounds, ANegativeMptIsRefused) +TEST_F(FloatFromSTAmountBounds, a_negative_mpt_is_refused) { EXPECT_CALL(host, floatFromSTAmount).Times(0); @@ -173,7 +173,7 @@ TEST_F(FloatFromSTAmountBounds, ANegativeMptIsRefused) // `isLegalNet`'s half: the XRP branch skips `canonicalize` too, so drops past the network // maximum reach the host unchallenged without this. -TEST_F(FloatFromSTAmountBounds, XrpDropsPastTheNetworkMaximumAreRefused) +TEST_F(FloatFromSTAmountBounds, xrp_drops_past_the_network_maximum_are_refused) { EXPECT_CALL(host, floatFromSTAmount).Times(0); @@ -184,7 +184,7 @@ TEST_F(FloatFromSTAmountBounds, XrpDropsPastTheNetworkMaximumAreRefused) hfErrorToInt(HostFunctionError::InvalidParams)); } -TEST_F(FloatFromSTAmountBounds, TheMaximaThemselvesStillReachTheHost) +TEST_F(FloatFromSTAmountBounds, the_maxima_themselves_still_reach_the_host) { auto const result = Bytes{1, 2, 3}; EXPECT_CALL(host, floatFromSTAmount(testing::_, mode)) diff --git a/src/tests/libxrpl/tx/wasm/host_context/FloatFromSTNumber.cpp b/src/tests/libxrpl/tx/wasm/host_context/FloatFromSTNumber.cpp index da7231f925..53e6bd7ad0 100644 --- a/src/tests/libxrpl/tx/wasm/host_context/FloatFromSTNumber.cpp +++ b/src/tests/libxrpl/tx/wasm/host_context/FloatFromSTNumber.cpp @@ -124,28 +124,28 @@ struct FloatFromSTNumberRounding : HostContextTest } }; -TEST_F(FloatFromSTNumberRounding, TowardsZeroTruncatesInsteadOfRoundingToNearest) +TEST_F(FloatFromSTNumberRounding, towards_zero_truncates_instead_of_rounding_to_nearest) { expectDecodedAs(dropsSeven, Number::RoundingMode::TowardsZero, truncated); } -TEST_F(FloatFromSTNumberRounding, UpwardRoundsAwayInsteadOfRoundingToNearest) +TEST_F(FloatFromSTNumberRounding, upward_rounds_away_instead_of_rounding_to_nearest) { expectDecodedAs(dropsThree, Number::RoundingMode::Upward, raised); } -TEST_F(FloatFromSTNumberRounding, DownwardTruncatesInsteadOfRoundingToNearest) +TEST_F(FloatFromSTNumberRounding, downward_truncates_instead_of_rounding_to_nearest) { expectDecodedAs(dropsSeven, Number::RoundingMode::Downward, truncated); } -TEST_F(FloatFromSTNumberRounding, ToNearestIsUnchanged) +TEST_F(FloatFromSTNumberRounding, to_nearest_is_unchanged) { expectDecodedAs(dropsSeven, Number::RoundingMode::ToNearest, raised); expectDecodedAs(dropsThree, Number::RoundingMode::ToNearest, truncated); } -TEST_F(FloatFromSTNumberRounding, AnInvalidModeStillReachesTheHost) +TEST_F(FloatFromSTNumberRounding, an_invalid_mode_still_reaches_the_host) { constexpr auto kNotAMode = std::int32_t{99}; EXPECT_CALL(host, floatFromSTNumber(testing::_, kNotAMode))