ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2026-06-03 16:56:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

chore: Enable clang-tidy modernize checks (#6975)

Browse Source 
Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com>
Co-authored-by: Bart <bthomee@users.noreply.github.com>
This commit is contained in:
Alex Kremer
2026-04-21 16:32:51 +01:00
committed by GitHub
parent ab887f5049
commit ce3951bbb3
699 changed files with 4626 additions and 5292 deletions
Download Patch File Download Diff File Expand all files Collapse all files

44
src/test/protocol/TER_test.cpp
View File

@@ -51,20 +51,18 @@ struct TER_test : public beast::unit_test::suite
using To_t = std::decay_t<decltype(std::get<I1>(tup))>;
using From_t = std::decay_t<decltype(std::get<I2>(tup))>;
static_assert(
std::is_same<From_t, To_t>::value == std::is_convertible<From_t, To_t>::value,
"Convert err");
std::is_same_v<From_t, To_t> == std::is_convertible_v<From_t, To_t>, "Convert err");
static_assert(
std::is_same<To_t, From_t>::value == std::is_constructible<To_t, From_t>::value,
std::is_same_v<To_t, From_t> == std::is_constructible_v<To_t, From_t>,
"Construct err");
static_assert(
std::is_same<To_t, From_t>::value ==
std::is_assignable<To_t&, From_t const&>::value,
std::is_same_v<To_t, From_t> == std::is_assignable_v<To_t&, From_t const&>,
"Assign err");
// Assignment or conversion from integer to type should never work.
static_assert(!std::is_convertible<int, To_t>::value, "Convert err");
static_assert(!std::is_constructible<To_t, int>::value, "Construct err");
static_assert(!std::is_assignable<To_t&, int const&>::value, "Assign err");
static_assert(!std::is_convertible_v<int, To_t>, "Convert err");
static_assert(!std::is_constructible_v<To_t, int>, "Construct err");
static_assert(!std::is_assignable_v<To_t&, int const&>, "Assign err");
}
};
@@ -93,7 +91,7 @@ struct TER_test : public beast::unit_test::suite
{
Func<I1, I2> const func;
func(tup, s);
testIterate<std::tuple_size<Tup>::value - 1, I2 - 1, Func>(tup, s);
testIterate<std::tuple_size_v<Tup> - 1, I2 - 1, Func>(tup, s);
}
// Finish iteration over the tuple.
@@ -118,7 +116,7 @@ struct TER_test : public beast::unit_test::suite
// Examples of each kind of enum.
static auto const terEnums = std::make_tuple(
telLOCAL_ERROR, temMALFORMED, tefFAILURE, terRETRY, tesSUCCESS, tecCLAIM);
static int const hiIndex{std::tuple_size<decltype(terEnums)>::value - 1};
static int const hiIndex{std::tuple_size_v<decltype(terEnums)> - 1};
// Verify that enums cannot be converted to other enum types.
testIterate<hiIndex, hiIndex, NotConvertible>(terEnums, *this);
@@ -127,9 +125,9 @@ struct TER_test : public beast::unit_test::suite
auto isConvertible = [](auto from, auto to) {
using From_t = std::decay_t<decltype(from)>;
using To_t = std::decay_t<decltype(to)>;
static_assert(std::is_convertible<From_t, To_t>::value, "Convert err");
static_assert(std::is_constructible<To_t, From_t>::value, "Construct err");
static_assert(std::is_assignable<To_t&, From_t const&>::value, "Assign err");
static_assert(std::is_convertible_v<From_t, To_t>, "Convert err");
static_assert(std::is_constructible_v<To_t, From_t>, "Construct err");
static_assert(std::is_assignable_v<To_t&, From_t const&>, "Assign err");
};
// Verify the right types convert to NotTEC.
@@ -145,9 +143,9 @@ struct TER_test : public beast::unit_test::suite
auto notConvertible = [](auto from, auto to) {
using To_t = std::decay_t<decltype(to)>;
using From_t = std::decay_t<decltype(from)>;
static_assert(!std::is_convertible<From_t, To_t>::value, "Convert err");
static_assert(!std::is_constructible<To_t, From_t>::value, "Construct err");
static_assert(!std::is_assignable<To_t&, From_t const&>::value, "Assign err");
static_assert(!std::is_convertible_v<From_t, To_t>, "Convert err");
static_assert(!std::is_constructible_v<To_t, From_t>, "Construct err");
static_assert(!std::is_assignable_v<To_t&, From_t const&>, "Assign err");
};
// Verify types that shouldn't convert to NotTEC.
@@ -189,17 +187,17 @@ struct TER_test : public beast::unit_test::suite
auto const lhs = std::get<I1>(tup);
auto const rhs = std::get<I2>(tup);
static_assert(std::is_same<decltype(operator==(lhs, rhs)), bool>::value, "== err");
static_assert(std::is_same_v<decltype(operator==(lhs, rhs)), bool>, "== err");
static_assert(std::is_same<decltype(operator!=(lhs, rhs)), bool>::value, "!= err");
static_assert(std::is_same_v<decltype(operator!=(lhs, rhs)), bool>, "!= err");
static_assert(std::is_same<decltype(operator<(lhs, rhs)), bool>::value, "< err");
static_assert(std::is_same_v<decltype(operator<(lhs, rhs)), bool>, "< err");
static_assert(std::is_same<decltype(operator<=(lhs, rhs)), bool>::value, "<= err");
static_assert(std::is_same_v<decltype(operator<=(lhs, rhs)), bool>, "<= err");
static_assert(std::is_same<decltype(operator>(lhs, rhs)), bool>::value, "> err");
static_assert(std::is_same_v<decltype(operator>(lhs, rhs)), bool>, "> err");
static_assert(std::is_same<decltype(operator>=(lhs, rhs)), bool>::value, ">= err");
static_assert(std::is_same_v<decltype(operator>=(lhs, rhs)), bool>, ">= err");
// Make sure a sampling of TER types exhibit the expected behavior
// for all comparison operators.
@@ -227,7 +225,7 @@ struct TER_test : public beast::unit_test::suite
tecCLAIM,
NotTEC{telLOCAL_ERROR},
TER{tecCLAIM});
static int const hiIndex{std::tuple_size<decltype(ters)>::value - 1};
static int const hiIndex{std::tuple_size_v<decltype(ters)> - 1};
// Verify that all types in the ters tuple can be compared with all
// the other types in ters.