refactor: Use more scoped enums (#7086)

This commit is contained in:
Alex Kremer
2026-05-11 16:39:48 +01:00
committed by GitHub
parent 779b49cd93
commit cdee9a675c
379 changed files with 2771 additions and 2864 deletions

View File

@@ -75,9 +75,9 @@ public:
testInvalidAccountParam(1);
testInvalidAccountParam(1.1);
testInvalidAccountParam(true);
testInvalidAccountParam(json::Value(json::NullValue));
testInvalidAccountParam(json::Value(json::ObjectValue));
testInvalidAccountParam(json::Value(json::ArrayValue));
testInvalidAccountParam(json::Value(json::ValueType::Null));
testInvalidAccountParam(json::Value(json::ValueType::Object));
testInvalidAccountParam(json::Value(json::ValueType::Array));
}
Account const alice{"alice"};
{
@@ -215,7 +215,7 @@ public:
// Invalid index
json::Value params;
params[jss::account] = alice.human();
params[jss::ledger_index] = json::ObjectValue;
params[jss::ledger_index] = json::ValueType::Object;
auto const lines = env.rpc("json", "account_lines", to_string(params))[jss::result];
BEAST_EXPECT(lines[jss::error] == "invalidParams");
BEAST_EXPECT(
@@ -528,7 +528,7 @@ public:
jv[jss::TransactionType] = jss::PaymentChannelCreate;
jv[jss::Account] = account.human();
jv[jss::Destination] = to.human();
jv[jss::Amount] = amount.getJson(JsonOptions::KNone);
jv[jss::Amount] = amount.getJson(JsonOptions::Values::None);
jv["SettleDelay"] = settleDelay.count();
jv["PublicKey"] = strHex(pk.slice());
return jv;
@@ -618,7 +618,7 @@ public:
// the list will be empty for most calls.
auto getNextLine =
[](Env& env, Account const& alice, std::optional<std::string> const marker) {
json::Value params(json::ObjectValue);
json::Value params(json::ValueType::Object);
params[jss::account] = alice.human();
params[jss::limit] = 1;
if (marker)