refactor: Use more scoped enums (#7086)

This commit is contained in:
Alex Kremer
2026-05-11 16:39:48 +01:00
committed by GitHub
parent 779b49cd93
commit cdee9a675c
379 changed files with 2771 additions and 2864 deletions

View File

@@ -17,7 +17,7 @@ struct STInteger_test : public beast::unit_test::Suite
BEAST_EXPECT(u8.value() == 255);
BEAST_EXPECT(u8.getText() == "255");
BEAST_EXPECT(u8.getSType() == STI_UINT8);
BEAST_EXPECT(u8.getJson(JsonOptions::KNone) == 255);
BEAST_EXPECT(u8.getJson(JsonOptions::Values::None) == 255);
// there is some special handling for sfTransactionResult
STUInt8 const tr(sfTransactionResult, 0);
@@ -25,14 +25,14 @@ struct STInteger_test : public beast::unit_test::Suite
BEAST_EXPECT(
tr.getText() == "The transaction was applied. Only final in a validated ledger.");
BEAST_EXPECT(tr.getSType() == STI_UINT8);
BEAST_EXPECT(tr.getJson(JsonOptions::KNone) == "tesSUCCESS");
BEAST_EXPECT(tr.getJson(JsonOptions::Values::None) == "tesSUCCESS");
// invalid transaction result
STUInt8 const tr2(sfTransactionResult, 255);
BEAST_EXPECT(tr2.value() == 255);
BEAST_EXPECT(tr2.getText() == "255");
BEAST_EXPECT(tr2.getSType() == STI_UINT8);
BEAST_EXPECT(tr2.getJson(JsonOptions::KNone) == 255);
BEAST_EXPECT(tr2.getJson(JsonOptions::Values::None) == 255);
}
void
@@ -43,21 +43,21 @@ struct STInteger_test : public beast::unit_test::Suite
BEAST_EXPECT(u16.value() == 65535);
BEAST_EXPECT(u16.getText() == "65535");
BEAST_EXPECT(u16.getSType() == STI_UINT16);
BEAST_EXPECT(u16.getJson(JsonOptions::KNone) == 65535);
BEAST_EXPECT(u16.getJson(JsonOptions::Values::None) == 65535);
// there is some special handling for sfLedgerEntryType
STUInt16 const let(sfLedgerEntryType, ltACCOUNT_ROOT);
BEAST_EXPECT(let.value() == ltACCOUNT_ROOT);
BEAST_EXPECT(let.getText() == "AccountRoot");
BEAST_EXPECT(let.getSType() == STI_UINT16);
BEAST_EXPECT(let.getJson(JsonOptions::KNone) == "AccountRoot");
BEAST_EXPECT(let.getJson(JsonOptions::Values::None) == "AccountRoot");
// there is some special handling for sfTransactionType
STUInt16 const tlt(sfTransactionType, ttPAYMENT);
BEAST_EXPECT(tlt.value() == ttPAYMENT);
BEAST_EXPECT(tlt.getText() == "Payment");
BEAST_EXPECT(tlt.getSType() == STI_UINT16);
BEAST_EXPECT(tlt.getJson(JsonOptions::KNone) == "Payment");
BEAST_EXPECT(tlt.getJson(JsonOptions::Values::None) == "Payment");
}
void
@@ -68,19 +68,19 @@ struct STInteger_test : public beast::unit_test::Suite
BEAST_EXPECT(u32.value() == 4'294'967'295u);
BEAST_EXPECT(u32.getText() == "4294967295");
BEAST_EXPECT(u32.getSType() == STI_UINT32);
BEAST_EXPECT(u32.getJson(JsonOptions::KNone) == 4'294'967'295u);
BEAST_EXPECT(u32.getJson(JsonOptions::Values::None) == 4'294'967'295u);
// there is some special handling for sfPermissionValue
STUInt32 const pv(sfPermissionValue, ttPAYMENT + 1);
BEAST_EXPECT(pv.value() == ttPAYMENT + 1);
BEAST_EXPECT(pv.getText() == "Payment");
BEAST_EXPECT(pv.getSType() == STI_UINT32);
BEAST_EXPECT(pv.getJson(JsonOptions::KNone) == "Payment");
BEAST_EXPECT(pv.getJson(JsonOptions::Values::None) == "Payment");
STUInt32 const pv2(sfPermissionValue, PaymentMint);
BEAST_EXPECT(pv2.value() == PaymentMint);
BEAST_EXPECT(pv2.getText() == "PaymentMint");
BEAST_EXPECT(pv2.getSType() == STI_UINT32);
BEAST_EXPECT(pv2.getJson(JsonOptions::KNone) == "PaymentMint");
BEAST_EXPECT(pv2.getJson(JsonOptions::Values::None) == "PaymentMint");
}
void
@@ -93,7 +93,7 @@ struct STInteger_test : public beast::unit_test::Suite
BEAST_EXPECT(u64.getSType() == STI_UINT64);
// By default, getJson returns hex string
auto jsonVal = u64.getJson(JsonOptions::KNone);
auto jsonVal = u64.getJson(JsonOptions::Values::None);
BEAST_EXPECT(jsonVal.isString());
BEAST_EXPECT(jsonVal.asString() == "ffffffffffffffff");
@@ -101,7 +101,7 @@ struct STInteger_test : public beast::unit_test::Suite
BEAST_EXPECT(u642.value() == 0xFFFFFFFFFFFFFFFFull);
BEAST_EXPECT(u642.getText() == "18446744073709551615");
BEAST_EXPECT(u642.getSType() == STI_UINT64);
BEAST_EXPECT(u642.getJson(JsonOptions::KNone) == "18446744073709551615");
BEAST_EXPECT(u642.getJson(JsonOptions::Values::None) == "18446744073709551615");
}
void
@@ -114,7 +114,7 @@ struct STInteger_test : public beast::unit_test::Suite
BEAST_EXPECT(i32.value() == minInt32);
BEAST_EXPECT(i32.getText() == "-2147483648");
BEAST_EXPECT(i32.getSType() == STI_INT32);
BEAST_EXPECT(i32.getJson(JsonOptions::KNone) == minInt32);
BEAST_EXPECT(i32.getJson(JsonOptions::Values::None) == minInt32);
}
{
@@ -123,7 +123,7 @@ struct STInteger_test : public beast::unit_test::Suite
BEAST_EXPECT(i32.value() == maxInt32);
BEAST_EXPECT(i32.getText() == "2147483647");
BEAST_EXPECT(i32.getSType() == STI_INT32);
BEAST_EXPECT(i32.getJson(JsonOptions::KNone) == maxInt32);
BEAST_EXPECT(i32.getJson(JsonOptions::Values::None) == maxInt32);
}
}