refactor: Use more scoped enums (#7086)

This commit is contained in:
Alex Kremer
2026-05-11 16:39:48 +01:00
committed by GitHub
parent 779b49cd93
commit cdee9a675c
379 changed files with 2771 additions and 2864 deletions

View File

@@ -95,12 +95,14 @@ class Freeze_test : public beast::unit_test::Suite
// Is created via a TrustSet with SetFreeze flag
// test: sets LowFreeze | HighFreeze flags
env(trust(g1, bob["USD"](0), tfSetFreeze));
auto affected = env.meta()->getJson(JsonOptions::KNone)[sfAffectedNodes.fieldName];
auto affected =
env.meta()->getJson(JsonOptions::Values::None)[sfAffectedNodes.fieldName];
if (!BEAST_EXPECT(checkArraySize(affected, 2u)))
return;
auto ff = affected[1u][sfModifiedNode.fieldName][sfFinalFields.fieldName];
BEAST_EXPECT(
ff[sfLowLimit.fieldName] == g1["USD"](0).value().getJson(JsonOptions::KNone));
ff[sfLowLimit.fieldName] ==
g1["USD"](0).value().getJson(JsonOptions::Values::None));
BEAST_EXPECT(ff[jss::Flags].asUInt() & lsfLowFreeze);
BEAST_EXPECT(!(ff[jss::Flags].asUInt() & lsfHighFreeze));
env.close();
@@ -110,14 +112,16 @@ class Freeze_test : public beast::unit_test::Suite
// Account with line frozen by issuer
// test: can buy more assets on that line
env(offer(bob, g1["USD"](5), XRP(25)));
auto affected = env.meta()->getJson(JsonOptions::KNone)[sfAffectedNodes.fieldName];
auto affected =
env.meta()->getJson(JsonOptions::Values::None)[sfAffectedNodes.fieldName];
if (!BEAST_EXPECT(checkArraySize(affected, 5u)))
return;
auto ff = affected[3u][sfModifiedNode.fieldName][sfFinalFields.fieldName];
BEAST_EXPECT(
ff[sfHighLimit.fieldName] == bob["USD"](100).value().getJson(JsonOptions::KNone));
ff[sfHighLimit.fieldName] ==
bob["USD"](100).value().getJson(JsonOptions::Values::None));
auto amt = STAmount{Issue{toCurrency("USD"), noAccount()}, -15}.value().getJson(
JsonOptions::KNone);
JsonOptions::Values::None);
BEAST_EXPECT(ff[sfBalance.fieldName] == amt);
env.close();
}
@@ -174,12 +178,14 @@ class Freeze_test : public beast::unit_test::Suite
// Is cleared via a TrustSet with ClearFreeze flag
// test: sets LowFreeze | HighFreeze flags
env(trust(g1, bob["USD"](0), tfClearFreeze));
auto affected = env.meta()->getJson(JsonOptions::KNone)[sfAffectedNodes.fieldName];
auto affected =
env.meta()->getJson(JsonOptions::Values::None)[sfAffectedNodes.fieldName];
if (!BEAST_EXPECT(checkArraySize(affected, 2u)))
return;
auto ff = affected[1u][sfModifiedNode.fieldName][sfFinalFields.fieldName];
BEAST_EXPECT(
ff[sfLowLimit.fieldName] == g1["USD"](0).value().getJson(JsonOptions::KNone));
ff[sfLowLimit.fieldName] ==
g1["USD"](0).value().getJson(JsonOptions::Values::None));
BEAST_EXPECT(!(ff[jss::Flags].asUInt() & lsfLowFreeze));
BEAST_EXPECT(!(ff[jss::Flags].asUInt() & lsfHighFreeze));
env.close();
@@ -359,7 +365,8 @@ class Freeze_test : public beast::unit_test::Suite
// trust line
env(trust(g1, a1["USD"](0), tfSetFreeze | tfClearFreeze));
{
auto affected = env.meta()->getJson(JsonOptions::KNone)[sfAffectedNodes.fieldName];
auto affected =
env.meta()->getJson(JsonOptions::Values::None)[sfAffectedNodes.fieldName];
BEAST_EXPECT(checkArraySize(affected, 1u)); // means no trustline changes
}
}
@@ -599,7 +606,8 @@ class Freeze_test : public beast::unit_test::Suite
// test: previous functionality, checking there's no changes to a
// trust line
env(trust(g1, a1["USD"](0), tfSetFreeze));
auto affected = env.meta()->getJson(JsonOptions::KNone)[sfAffectedNodes.fieldName];
auto affected =
env.meta()->getJson(JsonOptions::Values::None)[sfAffectedNodes.fieldName];
if (!BEAST_EXPECT(checkArraySize(affected, 1u)))
return;
@@ -665,7 +673,8 @@ class Freeze_test : public beast::unit_test::Suite
if (!BEAST_EXPECT(checkArraySize(offers, 1u)))
return;
BEAST_EXPECT(
offers[0u][jss::taker_gets] == g1["USD"](999).value().getJson(JsonOptions::KNone));
offers[0u][jss::taker_gets] ==
g1["USD"](999).value().getJson(JsonOptions::Values::None));
// test: someone else creates an offer providing liquidity
env(offer(a4, XRP(999), g1["USD"](999)));
@@ -673,11 +682,12 @@ class Freeze_test : public beast::unit_test::Suite
// test: owner of partially consumed offers line is frozen
env(trust(g1, a3["USD"](0), tfSetFreeze));
auto affected = env.meta()->getJson(JsonOptions::KNone)[sfAffectedNodes.fieldName];
auto affected = env.meta()->getJson(JsonOptions::Values::None)[sfAffectedNodes.fieldName];
if (!BEAST_EXPECT(checkArraySize(affected, 2u)))
return;
auto ff = affected[1u][sfModifiedNode.fieldName][sfFinalFields.fieldName];
BEAST_EXPECT(ff[sfHighLimit.fieldName] == g1["USD"](0).value().getJson(JsonOptions::KNone));
BEAST_EXPECT(
ff[sfHighLimit.fieldName] == g1["USD"](0).value().getJson(JsonOptions::Values::None));
BEAST_EXPECT(!(ff[jss::Flags].asUInt() & lsfLowFreeze));
BEAST_EXPECT(ff[jss::Flags].asUInt() & lsfHighFreeze);
env.close();
@@ -699,18 +709,19 @@ class Freeze_test : public beast::unit_test::Suite
// removal buy successful OfferCreate
// test: freeze the new offer
env(trust(g1, a4["USD"](0), tfSetFreeze));
affected = env.meta()->getJson(JsonOptions::KNone)[sfAffectedNodes.fieldName];
affected = env.meta()->getJson(JsonOptions::Values::None)[sfAffectedNodes.fieldName];
if (!BEAST_EXPECT(checkArraySize(affected, 2u)))
return;
ff = affected[0u][sfModifiedNode.fieldName][sfFinalFields.fieldName];
BEAST_EXPECT(ff[sfLowLimit.fieldName] == g1["USD"](0).value().getJson(JsonOptions::KNone));
BEAST_EXPECT(
ff[sfLowLimit.fieldName] == g1["USD"](0).value().getJson(JsonOptions::Values::None));
BEAST_EXPECT(ff[jss::Flags].asUInt() & lsfLowFreeze);
BEAST_EXPECT(!(ff[jss::Flags].asUInt() & lsfHighFreeze));
env.close();
// test: can no longer create a crossing offer
env(offer(a2, g1["USD"](999), XRP(999)));
affected = env.meta()->getJson(JsonOptions::KNone)[sfAffectedNodes.fieldName];
affected = env.meta()->getJson(JsonOptions::Values::None)[sfAffectedNodes.fieldName];
if (!BEAST_EXPECT(checkArraySize(affected, 8u)))
return;
auto created = affected[0u][sfCreatedNode.fieldName];
@@ -1914,7 +1925,8 @@ class Freeze_test : public beast::unit_test::Suite
bool modified = true)
{
using namespace test::jtx;
auto const affected = env.meta()->getJson(JsonOptions::KNone)[sfAffectedNodes.fieldName];
auto const affected =
env.meta()->getJson(JsonOptions::Values::None)[sfAffectedNodes.fieldName];
if (!BEAST_EXPECT(checkArraySize(affected, expectedArraySize)))
return 0;