refactor: Use more scoped enums (#7086)

This commit is contained in:
Alex Kremer
2026-05-11 16:39:48 +01:00
committed by GitHub
parent 779b49cd93
commit cdee9a675c
379 changed files with 2771 additions and 2864 deletions

View File

@@ -553,11 +553,11 @@ private:
{
// bad preflight1
json::Value jv = json::ObjectValue;
json::Value jv = json::ValueType::Object;
jv[jss::Account] = alice_.human();
jv[jss::TransactionType] = jss::AMMDeposit;
jv[jss::Asset] = STIssue(sfAsset, XRP).getJson(JsonOptions::KNone);
jv[jss::Asset2] = STIssue(sfAsset, USD).getJson(JsonOptions::KNone);
jv[jss::Asset] = STIssue(sfAsset, XRP).getJson(JsonOptions::Values::None);
jv[jss::Asset2] = STIssue(sfAsset, USD).getJson(JsonOptions::Values::None);
jv[jss::Fee] = "-1";
env(jv, Ter(temBAD_FEE));
}
@@ -568,12 +568,12 @@ private:
alice_, IOUAmount{-1}, std::nullopt, std::nullopt, Ter(temBAD_AMM_TOKENS));
{
json::Value jv = json::ObjectValue;
json::Value jv = json::ValueType::Object;
jv[jss::Account] = alice_.human();
jv[jss::TransactionType] = jss::AMMDeposit;
jv[jss::Asset] = STIssue(sfAsset, XRP).getJson(JsonOptions::KNone);
jv[jss::Asset2] = STIssue(sfAsset, USD).getJson(JsonOptions::KNone);
jv[jss::LPTokenOut] = USD(100).value().getJson(JsonOptions::KNone);
jv[jss::Asset] = STIssue(sfAsset, XRP).getJson(JsonOptions::Values::None);
jv[jss::Asset2] = STIssue(sfAsset, USD).getJson(JsonOptions::Values::None);
jv[jss::LPTokenOut] = USD(100).value().getJson(JsonOptions::Values::None);
jv[jss::Flags] = tfLPToken;
env(jv, Ter(temBAD_AMM_TOKENS));
}
@@ -5216,7 +5216,8 @@ private:
fail();
}
amm.deposit(carol_, 1'000);
auto affected = env.meta()->getJson(JsonOptions::KNone)[sfAffectedNodes.fieldName];
auto affected =
env.meta()->getJson(JsonOptions::Values::None)[sfAffectedNodes.fieldName];
try
{
bool found = false;