refactor: Use more scoped enums (#7086)

This commit is contained in:
Alex Kremer
2026-05-11 16:39:48 +01:00
committed by GitHub
parent 779b49cd93
commit cdee9a675c
379 changed files with 2771 additions and 2864 deletions

View File

@@ -411,13 +411,14 @@ private:
// LPTokenOut can not be MPT
{
json::Value jv = json::ObjectValue;
json::Value jv = json::ValueType::Object;
jv[jss::Account] = alice_.human();
jv[jss::TransactionType] = jss::AMMDeposit;
jv[jss::Asset] = STIssue(sfAsset, XRP).getJson(JsonOptions::KNone);
jv[jss::Asset] = STIssue(sfAsset, XRP).getJson(JsonOptions::Values::None);
jv[jss::Asset2] =
STIssue(sfAsset, MPT(ammAlice[1])).getJson(JsonOptions::KNone);
jv[jss::LPTokenOut] = MPT(ammAlice[1])(100).value().getJson(JsonOptions::KNone);
STIssue(sfAsset, MPT(ammAlice[1])).getJson(JsonOptions::Values::None);
jv[jss::LPTokenOut] =
MPT(ammAlice[1])(100).value().getJson(JsonOptions::Values::None);
jv[jss::Flags] = tfLPToken;
env(jv, Ter(telENV_RPC_FAILED));
}
@@ -425,13 +426,13 @@ private:
// Provided LPTokenOut does not match AMM pool's LPToken
// asset
{
json::Value jv = json::ObjectValue;
json::Value jv = json::ValueType::Object;
jv[jss::Account] = alice_.human();
jv[jss::TransactionType] = jss::AMMDeposit;
jv[jss::Asset] = STIssue(sfAsset, XRP).getJson(JsonOptions::KNone);
jv[jss::Asset] = STIssue(sfAsset, XRP).getJson(JsonOptions::Values::None);
jv[jss::Asset2] =
STIssue(sfAsset, MPT(ammAlice[1])).getJson(JsonOptions::KNone);
jv[jss::LPTokenOut] = USD(100).value().getJson(JsonOptions::KNone);
STIssue(sfAsset, MPT(ammAlice[1])).getJson(JsonOptions::Values::None);
jv[jss::LPTokenOut] = USD(100).value().getJson(JsonOptions::Values::None);
jv[jss::Flags] = tfLPToken;
env(jv, Ter(temBAD_AMM_TOKENS));
}
@@ -6256,7 +6257,8 @@ private:
amm.deposit(carol_, 1'000);
auto affected = env.meta()->getJson(JsonOptions::KNone)[sfAffectedNodes.fieldName];
auto affected =
env.meta()->getJson(JsonOptions::Values::None)[sfAffectedNodes.fieldName];
try
{
bool found = false;