From cd3a6bf530563b0b739fd02fb9d0eee1b5d70264 Mon Sep 17 00:00:00 2001
From: Wo Jake <87929946+wojake@users.noreply.github.com>
Date: Tue, 2 Aug 2022 08:36:12 +0000
Subject: [PATCH] Document the "DefaultVote::no" policy in the code

---
 src/ripple/protocol/impl/Feature.cpp | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/ripple/protocol/impl/Feature.cpp b/src/ripple/protocol/impl/Feature.cpp
index 4060067e30..fcd774ce9f 100644
--- a/src/ripple/protocol/impl/Feature.cpp
+++ b/src/ripple/protocol/impl/Feature.cpp
@@ -52,7 +52,7 @@ enum class Supported : bool { no = false, yes };
 // enabled using run-time conditionals based on the state of the amendment.
 // There is value in retaining that conditional code for some time after
 // the amendment is enabled to make it simple to replay old transactions.
-// However, once an Amendment has been enabled for, say, more than two years
+// However, once an amendment has been enabled for, say, more than two years
 // then retaining that conditional code has less value since it is
 // uncommon to replay such old transactions.
 //
@@ -61,10 +61,15 @@ enum class Supported : bool { no = false, yes };
 // 2018 needs to happen on an older version of the server code.  There's
 // a log message in Application.cpp that warns about replaying old ledgers.
 //
-// At some point in the future someone may wish to remove Amendment
-// conditional code for Amendments that were enabled after January 2018.
+// At some point in the future someone may wish to remove amendment
+// conditional code for amendments that were enabled after January 2018.
 // When that happens then the log message in Application.cpp should be
 // updated.
+//
+// Generally, amendments which introduce new features should be set as
+// "DefaultVote::no" whereas in rare cases, amendments that fix critical
+// bugs should be set as "DefaultVote::yes", if off-chain consensus is
+// reached amongst reviewers, validator operators, and other participants.
 
 class FeatureCollections
 {