fix: code gen

This commit is contained in:
Vito
2026-06-08 12:38:52 +02:00
parent a4f5f28edd
commit c9f6a606be
2 changed files with 34 additions and 13 deletions

View File

@@ -59,7 +59,7 @@ public:
}
/**
* @brief Get sfMemoData (soeOPTIONAL)
* @brief Get sfMemoData (SoeOptional)
* @return The field value, or std::nullopt if not present.
*/
[[nodiscard]]
@@ -139,7 +139,7 @@ public:
}
/**
* @brief Set sfMemoData (soeOPTIONAL)
* @brief Set sfMemoData (SoeOptional)
* @return Reference to this builder for method chaining.
*/
VaultDeleteBuilder&

View File

@@ -1,14 +1,16 @@
// Auto-generated unit tests for transaction VaultDelete
#include <xrpl/protocol/STTx.h>
#include <xrpl/protocol/SecretKey.h>
#include <xrpl/protocol/Seed.h>
#include <xrpl/protocol_autogen/transactions/AccountSet.h>
#include <xrpl/protocol_autogen/transactions/VaultDelete.h>
#include <gtest/gtest.h>
#include <protocol_autogen/TestHelpers.h>
#include <xrpl/protocol/SecretKey.h>
#include <xrpl/protocol/Seed.h>
#include <xrpl/protocol/STTx.h>
#include <xrpl/protocol_autogen/transactions/VaultDelete.h>
#include <xrpl/protocol_autogen/transactions/AccountSet.h>
#include <string>
namespace xrpl::transactions {
@@ -30,7 +32,12 @@ TEST(TransactionsVaultDeleteTests, BuilderSettersRoundTrip)
auto const vaultIDValue = canonical_UINT256();
auto const memoDataValue = canonical_VL();
VaultDeleteBuilder builder{accountValue, vaultIDValue, sequenceValue, feeValue};
VaultDeleteBuilder builder{
accountValue,
vaultIDValue,
sequenceValue,
feeValue
};
// Set optional fields
builder.setMemoData(memoDataValue);
@@ -64,6 +71,7 @@ TEST(TransactionsVaultDeleteTests, BuilderSettersRoundTrip)
expectEqualField(expected, *actualOpt, "sfMemoData");
EXPECT_TRUE(tx.hasMemoData());
}
}
// 2 & 4) Start from an STTx, construct a builder from it, build a new wrapper,
@@ -84,7 +92,12 @@ TEST(TransactionsVaultDeleteTests, BuilderFromStTxRoundTrip)
auto const memoDataValue = canonical_VL();
// Build an initial transaction
VaultDeleteBuilder initialBuilder{accountValue, vaultIDValue, sequenceValue, feeValue};
VaultDeleteBuilder initialBuilder{
accountValue,
vaultIDValue,
sequenceValue,
feeValue
};
initialBuilder.setMemoData(memoDataValue);
@@ -117,13 +130,15 @@ TEST(TransactionsVaultDeleteTests, BuilderFromStTxRoundTrip)
ASSERT_TRUE(actualOpt.has_value()) << "Optional field sfMemoData should be present";
expectEqualField(expected, *actualOpt, "sfMemoData");
}
}
// 3) Verify wrapper throws when constructed from wrong transaction type.
TEST(TransactionsVaultDeleteTests, WrapperThrowsOnWrongTxType)
{
// Build a valid transaction of a different type
auto const [pk, sk] = generateKeyPair(KeyType::Secp256k1, generateSeed("testWrongType"));
auto const [pk, sk] =
generateKeyPair(KeyType::Secp256k1, generateSeed("testWrongType"));
auto const account = calcAccountID(pk);
AccountSetBuilder wrongBuilder{account, 1, canonical_AMOUNT()};
@@ -136,7 +151,8 @@ TEST(TransactionsVaultDeleteTests, WrapperThrowsOnWrongTxType)
TEST(TransactionsVaultDeleteTests, BuilderThrowsOnWrongTxType)
{
// Build a valid transaction of a different type
auto const [pk, sk] = generateKeyPair(KeyType::Secp256k1, generateSeed("testWrongTypeBuilder"));
auto const [pk, sk] =
generateKeyPair(KeyType::Secp256k1, generateSeed("testWrongTypeBuilder"));
auto const account = calcAccountID(pk);
AccountSetBuilder wrongBuilder{account, 1, canonical_AMOUNT()};
@@ -160,7 +176,12 @@ TEST(TransactionsVaultDeleteTests, OptionalFieldsReturnNullopt)
// Transaction-specific required field values
auto const vaultIDValue = canonical_UINT256();
VaultDeleteBuilder builder{accountValue, vaultIDValue, sequenceValue, feeValue};
VaultDeleteBuilder builder{
accountValue,
vaultIDValue,
sequenceValue,
feeValue
};
// Do NOT set optional fields
@@ -171,4 +192,4 @@ TEST(TransactionsVaultDeleteTests, OptionalFieldsReturnNullopt)
EXPECT_FALSE(tx.getMemoData().has_value());
}
} // namespace xrpl::transactions
}