From c8a7b2af564e4033cd995ad2f323305cc4189630 Mon Sep 17 00:00:00 2001 From: JoelKatz Date: Thu, 23 Jan 2014 15:41:03 -0800 Subject: [PATCH] Prevent infinite loop in getBookPage --- src/ripple_app/misc/NetworkOPs.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/ripple_app/misc/NetworkOPs.cpp b/src/ripple_app/misc/NetworkOPs.cpp index 97b2c03176..0c5c62d47c 100644 --- a/src/ripple_app/misc/NetworkOPs.cpp +++ b/src/ripple_app/misc/NetworkOPs.cpp @@ -2793,7 +2793,7 @@ void NetworkOPsImp::getBookPage (Ledger::pointer lpLedger, const uint160& uTaker uint32 uTransferRate = lesActive.rippleTransferRate (uTakerGetsIssuerID); - while ((iLeft > 0) && obIterator.nextOffer ()) + while ((--iLeft > 0) && obIterator.nextOffer ()) { SLE::pointer sleOffer = obIterator.getCurrentOffer(); @@ -2891,7 +2891,6 @@ void NetworkOPsImp::getBookPage (Ledger::pointer lpLedger, const uint160& uTaker // Only provide funded offers and offers of the taker. Json::Value& jvOf = jvOffers.append (jvOffer); jvOf["quality"] = saDirRate.getText (); - --iLeft; } }