From c71296889013afcfccdf74356904aa324fd12d63 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Tue, 9 Jun 2026 18:49:17 +0100 Subject: [PATCH] removed non-accessible include Signed-off-by: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> --- src/libxrpl/telemetry/TelemetryConfig.cpp | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/libxrpl/telemetry/TelemetryConfig.cpp b/src/libxrpl/telemetry/TelemetryConfig.cpp index d90e1df05d..0863623f66 100644 --- a/src/libxrpl/telemetry/TelemetryConfig.cpp +++ b/src/libxrpl/telemetry/TelemetryConfig.cpp @@ -8,7 +8,6 @@ */ #include -#include #include #include @@ -43,8 +42,15 @@ constexpr char const* tracePeer = "trace_peer"; constexpr char const* traceLedger = "trace_ledger"; } // namespace key -/** Default values applied when a key is absent from the config. */ +/** Default values applied when a key is absent from the config. + + @note serviceName mirrors SystemParameters' systemName() ("xrpld") but + is duplicated here as a literal: the telemetry module deliberately does + not link xrpl.libxrpl.protocol, so including SystemParameters.h would + introduce an undeclared cross-module dependency. +*/ namespace dflt { +constexpr char const* serviceName = "xrpld"; constexpr char const* endpoint = "http://localhost:4318/v1/traces"; constexpr std::uint32_t batchSize = 512u; constexpr std::uint32_t batchDelayMs = 5000u; @@ -83,7 +89,7 @@ setupTelemetry( Telemetry::Setup setup; setup.enabled = section.valueOr(key::enabled, 0) != 0; - setup.serviceName = section.valueOr(key::serviceName, systemName()); + setup.serviceName = section.valueOr(key::serviceName, dflt::serviceName); setup.serviceVersion = version; setup.serviceInstanceId = section.valueOr(key::serviceInstanceId, nodePublicKey);