ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-12-06 17:27:55 +00:00
Code Issues Packages Projects Releases Wiki Activity

Change order of checks in amm_info: (#4924)

Browse Source 
* Change order of checks in amm_info

* Change amm_info error message in API version 3

* Change amm_info error tests
This commit is contained in:
Bronek Kozicki
2024-06-18 17:55:40 +01:00
committed by GitHub
parent 223e6c7590
commit c706926ee3
4 changed files with 136 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/test/jtx/impl/AMM.cpp
View File

@@ -163,7 +163,8 @@ AMM::ammRpcInfo(
std::optional<Issue> issue1,
std::optional<Issue> issue2,
std::optional<AccountID> const& ammAccount,
bool ignoreParams) const
bool ignoreParams,
unsigned apiVersion) const
{
Json::Value jv;
if (account)
@@ -191,7 +192,10 @@ AMM::ammRpcInfo(
if (ammAccount)
jv[jss::amm_account] = to_string(*ammAccount);
}
auto jr = env_.rpc("json", "amm_info", to_string(jv));
auto jr =
(apiVersion == RPC::apiInvalidVersion
? env_.rpc("json", "amm_info", to_string(jv))
: env_.rpc(apiVersion, "json", "amm_info", to_string(jv)));
if (jr.isObject() && jr.isMember(jss::result) &&
jr[jss::result].isMember(jss::status))
return jr[jss::result];