From c63cc88dc679bff2a786da9d40c5e66ec2c1b992 Mon Sep 17 00:00:00 2001
From: Ed Hennis <ed@ripple.com>
Date: Tue, 8 Apr 2025 11:34:56 -0400
Subject: [PATCH] Fix a couple more build errors

---
 src/test/jtx/TestHelpers.h                 | 8 ++++----
 src/xrpld/app/tx/detail/InvariantCheck.cpp | 4 +++-
 2 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/src/test/jtx/TestHelpers.h b/src/test/jtx/TestHelpers.h
index 1ef83bd61b..edda769b27 100644
--- a/src/test/jtx/TestHelpers.h
+++ b/src/test/jtx/TestHelpers.h
@@ -43,7 +43,7 @@ namespace jtx {
 */
 template <
     class SField,
-    class StoredValue = SField::type::value_type,
+    class StoredValue = typename SField::type::value_type,
     class OutputValue = StoredValue>
 struct JTxField
 {
@@ -168,8 +168,8 @@ template <class JTxField>
 struct JTxFieldWrapper
 {
     using JF = JTxField;
-    using SF = JF::SF;
-    using SV = JF::SV;
+    using SF = typename JF::SF;
+    using SV = typename JF::SV;
 
 protected:
     SF const& sfield_;
@@ -221,7 +221,7 @@ public:
     }
 };
 
-template <class SField, class StoredValue = SField::type::value_type>
+template <class SField, class StoredValue = typename SField::type::value_type>
 using simpleField = JTxFieldWrapper<JTxField<SField, StoredValue>>;
 
 // TODO We only need this long "requires" clause as polyfill, for C++20
diff --git a/src/xrpld/app/tx/detail/InvariantCheck.cpp b/src/xrpld/app/tx/detail/InvariantCheck.cpp
index a74e4eb63e..cb5073ee72 100644
--- a/src/xrpld/app/tx/detail/InvariantCheck.cpp
+++ b/src/xrpld/app/tx/detail/InvariantCheck.cpp
@@ -78,8 +78,10 @@ checkMyPrivilege(STTx const& tx, Privilege priv)
     switch (tx.getTxnType())
     {
 #include <xrpl/protocol/detail/transactions.macro>
+        // Deprecated types
+        default:
+            return false;
     }
-    return false;
 };
 
 #undef TRANSACTION