From c5f419121fa3d5eb59bb160b659dd2e98ff9e195 Mon Sep 17 00:00:00 2001 From: Pratik Mankawde <3397372+pratikmankawde@users.noreply.github.com> Date: Mon, 20 Jul 2026 17:50:19 +0100 Subject: [PATCH] Revert "ci(telemetry): recognize perf-iac identity labels in otel-naming Rule D" This reverts commit 48747bab4cc085a5ef4df25b6682a20441278153. --- .github/scripts/otel-naming/check_otel_naming.py | 2 -- .github/scripts/otel-naming/test_check_otel_naming.py | 6 ------ 2 files changed, 8 deletions(-) diff --git a/.github/scripts/otel-naming/check_otel_naming.py b/.github/scripts/otel-naming/check_otel_naming.py index a5ed07c0e4..41e8748075 100644 --- a/.github/scripts/otel-naming/check_otel_naming.py +++ b/.github/scripts/otel-naming/check_otel_naming.py @@ -822,8 +822,6 @@ def run_rule_d_dashboards( "service_instance_id", "job", "instance", - "xrpl_branch", # perf-iac identity label: git ref of the build under test - "xrpl_node_role", # perf-iac identity label: validator/peer role in the perf cluster } # A dashboard label is valid if it is a span attribute (L1), a native-metric # label (L6), or a Prometheus/Grafana builtin. diff --git a/.github/scripts/otel-naming/test_check_otel_naming.py b/.github/scripts/otel-naming/test_check_otel_naming.py index e22c31c54e..cf042b877b 100644 --- a/.github/scripts/otel-naming/test_check_otel_naming.py +++ b/.github/scripts/otel-naming/test_check_otel_naming.py @@ -744,12 +744,6 @@ class RuleDDashboards(unittest.TestCase): [], ) - def test_perf_iac_identity_labels_not_flagged(self): - self.assertEqual( - self._run('"expr": "sum by (xrpl_branch, xrpl_node_role) (x)"', set()), - [], - ) - def test_prometheus_name_label_not_flagged(self): # `__name__` is the Prometheus reserved metric-name label; the renamed # system-*.json dashboards use `sum by (le, __name__)`.