From c57ffdbcb874db3a1c61c83cceda7faeef0a9008 Mon Sep 17 00:00:00 2001 From: Bart Date: Thu, 22 Jan 2026 14:05:59 -0500 Subject: [PATCH] ci: Explicitly set version when exporting the Conan recipe (#6264) By default the Conan recipe extracts the version from `BuildInfo.cpp`, but in some of the cases we want to upload a recipe with a suffix derived from the commit hash. This currently then results in the uploading to fail, since there is a version mismatch. Here we explicitly set the version, and then simplify the steps in the upload workflow since we now need the recipe name (embedded within the conanfile.py but also needed when uploading), the recipe version, and the recipe ref (name/version). --- .github/workflows/reusable-upload-recipe.yml | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/.github/workflows/reusable-upload-recipe.yml b/.github/workflows/reusable-upload-recipe.yml index 9b25481f6a..b5b8798f09 100644 --- a/.github/workflows/reusable-upload-recipe.yml +++ b/.github/workflows/reusable-upload-recipe.yml @@ -49,10 +49,6 @@ jobs: id: version uses: ./.github/actions/generate-version - - name: Determine recipe reference - id: ref - run: echo "ref=xrpl/${{ steps.version.outputs.version }}" >> "${GITHUB_OUTPUT}" - - name: Set up Conan uses: ./.github/actions/setup-conan with: @@ -68,11 +64,10 @@ jobs: - name: Upload Conan recipe env: - RECIPE_REF: ${{ steps.ref.outputs.ref }} REMOTE_NAME: ${{ inputs.remote_name }} run: | - conan export . - conan upload --confirm --check --remote="${REMOTE_NAME}" ${RECIPE_REF} + conan export . --version=${{ steps.version.outputs.version }} + conan upload --confirm --check --remote="${REMOTE_NAME}" xrpl/${{ steps.version.outputs.version }} outputs: - ref: ${{ steps.ref.outputs.ref }} + ref: xrpl/${{ steps.version.outputs.version }}