ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-24 04:55:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rewrite the notification code to use smart pointers. This fixes several

Browse Source 
fatal race conditions in notifications. This makes failure to remove a
notification non-fatal (it will remove itself harmlessly when an attempt is
made to notify it).
This commit is contained in:
JoelKatz
2013-02-26 00:11:23 -08:00
parent 5fb29bb859
commit c570cca15e
8 changed files with 209 additions and 140 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/cpp/ripple/WSConnection.h
View File

@@ -6,6 +6,7 @@
#include <boost/weak_ptr.hpp>
#include <boost/asio.hpp>
#include <boost/enable_shared_from_this.hpp>
#include "WSDoor.h"
#include "Application.h"
@@ -28,7 +29,8 @@ class WSServerHandler;
// - Subscriptions
//
template <typename endpoint_type>
class WSConnection : public InfoSub, public IS_INSTANCE(WebSocketConnection)
class WSConnection : public InfoSub, public IS_INSTANCE(WebSocketConnection),
public boost::enable_shared_from_this< WSConnection<endpoint_type> >
{
public:
typedef typename endpoint_type::connection_type connection;
@@ -101,7 +103,7 @@ public:
return jvResult;
}
RPCHandler mRPCHandler(&mNetwork, this);
RPCHandler mRPCHandler(&mNetwork, this->shared_from_this());
Json::Value jvResult(Json::objectValue);
int iRole = mHandler->getPublic()