From c487b41d1ff4415f5530a1b11a18a13bbf9354ae Mon Sep 17 00:00:00 2001
From: Vito <5780819+Tapanito@users.noreply.github.com>
Date: Thu, 4 Sep 2025 12:40:33 +0200
Subject: [PATCH] reduce log verbosity

---
 src/xrpld/overlay/detail/ConnectAttempt.cpp | 10 ++++++++--
 src/xrpld/overlay/detail/PeerImp.cpp        | 17 +++++++++++++----
 2 files changed, 21 insertions(+), 6 deletions(-)

diff --git a/src/xrpld/overlay/detail/ConnectAttempt.cpp b/src/xrpld/overlay/detail/ConnectAttempt.cpp
index f1a622e289..d43569bda3 100644
--- a/src/xrpld/overlay/detail/ConnectAttempt.cpp
+++ b/src/xrpld/overlay/detail/ConnectAttempt.cpp
@@ -160,8 +160,14 @@ ConnectAttempt::onShutdown(error_code ec)
         // - stream_truncated: the tcp connection closed (no handshake) it could
         // occur if a peer does not perform a graceful disconnect
         // - broken_pipe: the peer is gone
-        if (ec != boost::asio::error::eof &&
-            ec != boost::asio::error::operation_aborted)
+        // - application data after close notify: benign SSL shutdown condition
+        bool shouldLog =
+            (ec != boost::asio::error::eof &&
+             ec != boost::asio::error::operation_aborted &&
+             ec.message().find("application data after close notify") ==
+                 std::string::npos);
+
+        if (shouldLog)
         {
             JLOG(journal_.debug()) << "onShutdown: " << ec.message();
         }
diff --git a/src/xrpld/overlay/detail/PeerImp.cpp b/src/xrpld/overlay/detail/PeerImp.cpp
index 9c1a6cc1f8..5aa1f5f2b5 100644
--- a/src/xrpld/overlay/detail/PeerImp.cpp
+++ b/src/xrpld/overlay/detail/PeerImp.cpp
@@ -669,8 +669,13 @@ PeerImp::onShutdown(error_code ec)
         // - stream_truncated: the tcp connection closed (no handshake) it could
         // occur if a peer does not perform a graceful disconnect
         // - broken_pipe: the peer is gone
-        if (ec != boost::asio::error::eof &&
-            ec != boost::asio::error::operation_aborted)
+        bool shouldLog =
+            (ec != boost::asio::error::eof &&
+             ec != boost::asio::error::operation_aborted &&
+             ec.message().find("application data after close notify") ==
+                 std::string::npos);
+
+        if (shouldLog)
         {
             JLOG(journal_.debug()) << "onShutdown: " << ec.message();
         }
@@ -715,8 +720,8 @@ PeerImp::setTimer(std::chrono::seconds interval)
     catch (std::exception const& ex)
     {
         JLOG(journal_.error()) << "setTimer: " << ex.what();
-        return close();
-    };
+        return shutdown();
+    }
 
     timer_.async_wait(bind_executor(
         strand_,
@@ -965,6 +970,9 @@ PeerImp::onReadMessage(error_code ec, std::size_t bytes_transferred)
 
         return fail("onReadMessage", ec);
     }
+    // we started shutdown, no reason to process further data
+    if (shutdown_)
+        return tryAsyncShutdown();
 
     if (auto stream = journal_.trace())
     {
@@ -1007,6 +1015,7 @@ PeerImp::onReadMessage(error_code ec, std::size_t bytes_transferred)
         read_buffer_.consume(bytes_consumed);
     }
 
+    // check if a shutdown was initiated while processing messages
     if (shutdown_)
         return tryAsyncShutdown();