mirror of
https://github.com/XRPLF/rippled.git
synced 2025-11-23 04:25:51 +00:00
Have OfferCreate require positive funds.
This commit is contained in:
@@ -1024,7 +1024,7 @@ bool STAmount::applyOffer(
|
||||
{
|
||||
saOfferGets.throwComparable(saTakerFunds);
|
||||
|
||||
assert(!saOfferFunds.isZero() && !saTakerFunds.isZero()); // Both must have funds.
|
||||
assert(saOfferFunds.isPositive() && saTakerFunds.isPositive()); // Both must have funds.
|
||||
assert(saOfferGets.isPositive() && saOfferPays.isPositive()); // Must not be a null offer.
|
||||
|
||||
// Limit offerer funds available, by transfer fees.
|
||||
|
||||
@@ -138,7 +138,7 @@ TER OfferCreateTransactor::takeOffers(
|
||||
STAmount saSubTakerGets = saTakerGets-saTakerGot; // How much more is wanted.
|
||||
|
||||
// Figure out next offer to take, if needed.
|
||||
if (saTakerFunds // Taker has funds available.
|
||||
if (saTakerFunds.isPositive() // Taker has funds available.
|
||||
&& saSubTakerPays.isPositive()
|
||||
&& saSubTakerGets.isPositive())
|
||||
{
|
||||
@@ -162,7 +162,7 @@ TER OfferCreateTransactor::takeOffers(
|
||||
}
|
||||
}
|
||||
|
||||
if (!saTakerFunds) // Taker has no funds.
|
||||
if (!saTakerFunds.isPositive()) // Taker has no funds.
|
||||
{
|
||||
// Done. Ran out of funds on previous round. As fees aren't calculated directly in this routine, funds are checked here.
|
||||
cLog(lsINFO) << "takeOffers: done: taker unfunded.";
|
||||
|
||||
Reference in New Issue
Block a user