ARCHIVE/rippled
1
0
Fork 0
mirror of https://github.com/XRPLF/rippled.git synced 2025-11-23 12:35:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

Have OfferCreate require positive funds.

Browse Source
This commit is contained in:
Arthur Britto
2013-04-26 11:14:18 -07:00
parent 3c35a1e8b7
commit c34b1eb9ee
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/cpp/ripple/Amount.cpp
View File

@@ -1024,7 +1024,7 @@ bool STAmount::applyOffer(
{ {
saOfferGets.throwComparable(saTakerFunds); saOfferGets.throwComparable(saTakerFunds);
assert(!saOfferFunds.isZero() && !saTakerFunds.isZero()); // Both must have funds. assert(saOfferFunds.isPositive() && saTakerFunds.isPositive()); // Both must have funds.
assert(saOfferGets.isPositive() && saOfferPays.isPositive()); // Must not be a null offer. assert(saOfferGets.isPositive() && saOfferPays.isPositive()); // Must not be a null offer.
// Limit offerer funds available, by transfer fees. // Limit offerer funds available, by transfer fees.

4
src/cpp/ripple/OfferCreateTransactor.cpp
View File

@@ -138,7 +138,7 @@ TER OfferCreateTransactor::takeOffers(
STAmount saSubTakerGets = saTakerGets-saTakerGot; // How much more is wanted. STAmount saSubTakerGets = saTakerGets-saTakerGot; // How much more is wanted.
// Figure out next offer to take, if needed. // Figure out next offer to take, if needed.
if (saTakerFunds // Taker has funds available. if (saTakerFunds.isPositive() // Taker has funds available.
&& saSubTakerPays.isPositive() && saSubTakerPays.isPositive()
&& saSubTakerGets.isPositive()) && saSubTakerGets.isPositive())
{ {
@@ -162,7 +162,7 @@ TER OfferCreateTransactor::takeOffers(
} }
} }
if (!saTakerFunds) // Taker has no funds. if (!saTakerFunds.isPositive()) // Taker has no funds.
{ {
// Done. Ran out of funds on previous round. As fees aren't calculated directly in this routine, funds are checked here. // Done. Ran out of funds on previous round. As fees aren't calculated directly in this routine, funds are checked here.
cLog(lsINFO) << "takeOffers: done: taker unfunded."; cLog(lsINFO) << "takeOffers: done: taker unfunded.";