From c33526f88d19f5869a28959c693403a5029a83fa Mon Sep 17 00:00:00 2001 From: Gregory Tsipenyuk Date: Mon, 11 May 2026 10:23:05 -0400 Subject: [PATCH] Address reviewer's feedback. --- src/libxrpl/protocol/STIssue.cpp | 8 -------- src/test/protocol/STIssue_test.cpp | 2 ++ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/src/libxrpl/protocol/STIssue.cpp b/src/libxrpl/protocol/STIssue.cpp index 0a7baa97e9..845e504ac7 100644 --- a/src/libxrpl/protocol/STIssue.cpp +++ b/src/libxrpl/protocol/STIssue.cpp @@ -59,19 +59,11 @@ STIssue::STIssue(SerialIter& sit, SField const& name) : STBase{name} auto const seqSize = sizeof(std::uint32_t); if (account == noAccount()) { - // get32() swaps BE wire bytes to host order; memcpy then stores - // host-order bytes into the MPTID. On LE this produces a - // byte-swapped MPTID relative to the canonical value from - // makeMptID(), but add() has the same inversion so the - // round-trip is consistent within a single-arch deployment. std::uint32_t sequence = sit.get32(); memcpy(mptID.data(), &sequence, sizeof(sequence)); } else { - // V2: read raw wire bytes directly into the MPTID. No byte - // swapping; the canonical BE layout from makeMptID() is - // preserved end-to-end. auto const rawBytes = sit.getRaw(seqSize); memcpy(mptID.data(), rawBytes.data(), rawBytes.size()); } diff --git a/src/test/protocol/STIssue_test.cpp b/src/test/protocol/STIssue_test.cpp index 0b8adb078c..55d0f3964d 100644 --- a/src/test/protocol/STIssue_test.cpp +++ b/src/test/protocol/STIssue_test.cpp @@ -18,6 +18,7 @@ #include #include +#include #include #include @@ -165,6 +166,7 @@ public: testcase("MPT serialization - serialized sequence bytes are canonical big-endian"); using namespace jtx; Account const alice{"alice"}; + BEAST_EXPECT(std::endian::native == std::endian::little); // Sequence 240 = 0x000000F0. // Canonical BE bytes a client would expect: {0x00, 0x00, 0x00, 0xF0}.