Split TransactionAcquire and DisputedTx

modules/ripple_data/protocol/ripple_ProtocolTypes.h

@@ -1,21 +1,44 @@
 #ifndef RIPPLE_PROTOCOLTYPES_H
 #define RIPPLE_PROTOCOLTYPES_H
 
+/*
+    Hashes are used to uniquely identify objects like
+    transactions, peers, validators, and accounts.
+
+    For historical reasons, some hashes are 256 bits and some are 160.
+
+    David:
+        "The theory is that you may need to communicate public keys
+         to others, so having them be shorter is a good idea. plus,
+         you can't arbitrarily tweak them because you wouldn't know
+         the corresponding private key anyway. So the security
+         requirements aren't as great."
+*/
+
 /** A ledger hash.
 */
 typedef uint256 LedgerHash;
 
 /** A ledger index.
 */
+// VFALCO TODO pick one. I like Index since its not an abbreviation
 typedef uint32 LedgerIndex;
 typedef uint32 LedgerSeq;
 
 /** A transaction identifier.
 */
+// VFALCO TODO maybe rename to TxHash
 typedef uint256 TxID;
 
 /** A transaction index.
 */
-typedef uint32 TxSeq;
+typedef uint32 TxSeq; // VFALCO NOTE Should read TxIndex or TxNum
+
+/** An account hash.
+
+    The hash is used to uniquely identify the account.
+*/
+//typedef uint160 AccountHash;
+//typedef uint260 ValidatorID;
 
 #endif