fix(telemetry): address code review findings for Phase 4 consensus tracing

Fix quorum attribute to use actual validator quorum instead of proposer
count, add missing ConsensusState::Expired handling in haveConsensus()
span, move ConsensusSpanNames.h to xrpld/consensus/ to resolve
levelization cycle, remove unused constants, enrich proposal receive
span with sequence, and correct stale documentation references.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

src/xrpld/app/consensus/RCLConsensus.cpp

@@ -1,6 +1,5 @@
 #include <xrpld/app/consensus/RCLConsensus.h>
 
-#include <xrpld/app/consensus/ConsensusSpanNames.h>
 #include <xrpld/app/consensus/RCLCensorshipDetector.h>
 #include <xrpld/app/consensus/RCLCxLedger.h>
 #include <xrpld/app/consensus/RCLCxPeerPos.h>
@@ -19,6 +18,7 @@
 #include <xrpld/app/misc/ValidatorKeys.h>
 #include <xrpld/app/misc/ValidatorList.h>
 #include <xrpld/consensus/Consensus.h>
+#include <xrpld/consensus/ConsensusSpanNames.h>
 #include <xrpld/consensus/ConsensusTypes.h>
 #include <xrpld/overlay/Overlay.h>
 #include <xrpld/overlay/predicates.h>
@@ -495,7 +495,8 @@ RCLConsensus::Adaptor::makeAcceptSpan(Result const& result)
     span->setAttribute(
         telemetry::cons_span::attr::roundTimeMs,
         static_cast<int64_t>(result.roundTime.read().count()));
-    span->setAttribute(telemetry::cons_span::attr::quorum, static_cast<int64_t>(result.proposers));
+    span->setAttribute(
+        telemetry::cons_span::attr::quorum, static_cast<int64_t>(app_.getValidators().quorum()));
     return span;
 }
 

src/xrpld/consensus/Consensus.h

@@ -1,8 +1,8 @@
 #pragma once
 
-#include <xrpld/app/consensus/ConsensusSpanNames.h>
 #include <xrpld/consensus/ConsensusParms.h>
 #include <xrpld/consensus/ConsensusProposal.h>
+#include <xrpld/consensus/ConsensusSpanNames.h>
 #include <xrpld/consensus/ConsensusTypes.h>
 #include <xrpld/consensus/DisputedTx.h>
 
@@ -1804,6 +1804,8 @@ Consensus<Adaptor>::haveConsensus(std::unique_ptr<std::stringstream> const& clog
         stateStr = "yes";
     else if (result_->state == ConsensusState::MovedOn)
         stateStr = "moved_on";
+    else if (result_->state == ConsensusState::Expired)
+        stateStr = "expired";
     span.setAttribute(cons_span::attr::result, stateStr);
 
     CLOG(clog) << "Consensus has been reached. ";

src/xrpld/consensus/ConsensusSpanNames.h

@@ -31,7 +31,7 @@
  *    +-- consensus.establish                     [main thread, child]
  *    |     Created: Consensus::startEstablishTracing()
  *    |     Ended:   Consensus::phaseEstablish() on accept
- *    |     Attrs:   converge_percent, tx_count, disputes_count
+ *    |     Attrs:   converge_percent, establish_count, proposers
  *    |
  *    +-- consensus.update_positions              [main thread]
  *    |     Created: Consensus::updateOurPositions()
@@ -166,9 +166,6 @@ inline constexpr auto resolutionDirection = join(xrplConsensus, makeStr("resolut
 inline constexpr auto convergePercent = join(xrplConsensus, makeStr("converge_percent"));
 /// "xrpl.consensus.establish_count"
 inline constexpr auto establishCount = join(xrplConsensus, makeStr("establish_count"));
-/// "xrpl.consensus.proposers_agreed"
-inline constexpr auto proposersAgreed = join(xrplConsensus, makeStr("proposers_agreed"));
-
 // Avalanche threshold attributes
 /// "xrpl.consensus.avalanche_threshold"
 inline constexpr auto avalancheThreshold = join(xrplConsensus, makeStr("avalanche_threshold"));
@@ -189,8 +186,6 @@ inline constexpr auto thresholdPercent = join(xrplConsensus, makeStr("threshold_
 inline constexpr auto result = join(xrplConsensus, makeStr("result"));
 /// "xrpl.consensus.quorum"
 inline constexpr auto quorum = join(xrplConsensus, makeStr("quorum"));
-/// "xrpl.consensus.validation_count"
-inline constexpr auto validationCount = join(xrplConsensus, makeStr("validation_count"));
 
 // Trace strategy attribute
 /// "xrpl.consensus.trace_strategy"

src/xrpld/overlay/detail/PeerImp.cpp

@@ -1,6 +1,5 @@
 #include <xrpld/overlay/detail/PeerImp.h>
 
-#include <xrpld/app/consensus/ConsensusSpanNames.h>
 #include <xrpld/app/consensus/RCLCxPeerPos.h>
 #include <xrpld/app/consensus/RCLValidations.h>
 #include <xrpld/app/ledger/InboundLedgers.h>
@@ -10,6 +9,7 @@
 #include <xrpld/app/misc/Transaction.h>
 #include <xrpld/app/misc/TxSpanNames.h>
 #include <xrpld/app/misc/ValidatorList.h>
+#include <xrpld/consensus/ConsensusSpanNames.h>
 #include <xrpld/consensus/Validations.h>
 #include <xrpld/overlay/Cluster.h>
 #include <xrpld/overlay/ClusterNode.h>
@@ -1963,6 +1963,7 @@ PeerImp::onMessage(std::shared_ptr<protocol::TMProposeSet> const& m)
         telemetry::seg::consensus,
         telemetry::cons_span::op::proposalReceive));
     span->setAttribute(telemetry::cons_span::attr::trusted, isTrusted);
+    span->setAttribute(telemetry::cons_span::attr::round, static_cast<int64_t>(set.proposeseq()));
 
     std::weak_ptr<PeerImp> const weak = shared_from_this();
     app_.getJobQueue().addJob(