From beb8a1872d43144e2774caf278d9fd6848af33ff Mon Sep 17 00:00:00 2001 From: Vito <5780819+Tapanito@users.noreply.github.com> Date: Mon, 8 Jun 2026 12:07:19 +0200 Subject: [PATCH] fix: Regenerate protocol autogenerated files --- .../transactions/VaultDelete.h | 4 +- .../transactions/VaultDeleteTests.cpp | 43 ++++++++++++++----- 2 files changed, 34 insertions(+), 13 deletions(-) diff --git a/include/xrpl/protocol_autogen/transactions/VaultDelete.h b/include/xrpl/protocol_autogen/transactions/VaultDelete.h index 3f7c2fa0a5..b4c08ae229 100644 --- a/include/xrpl/protocol_autogen/transactions/VaultDelete.h +++ b/include/xrpl/protocol_autogen/transactions/VaultDelete.h @@ -59,7 +59,7 @@ public: } /** - * @brief Get sfMemoData (soeOPTIONAL) + * @brief Get sfMemoData (SoeOptional) * @return The field value, or std::nullopt if not present. */ [[nodiscard]] @@ -139,7 +139,7 @@ public: } /** - * @brief Set sfMemoData (soeOPTIONAL) + * @brief Set sfMemoData (SoeOptional) * @return Reference to this builder for method chaining. */ VaultDeleteBuilder& diff --git a/src/tests/libxrpl/protocol_autogen/transactions/VaultDeleteTests.cpp b/src/tests/libxrpl/protocol_autogen/transactions/VaultDeleteTests.cpp index 48f7ff2a83..8f0eb2e4cd 100644 --- a/src/tests/libxrpl/protocol_autogen/transactions/VaultDeleteTests.cpp +++ b/src/tests/libxrpl/protocol_autogen/transactions/VaultDeleteTests.cpp @@ -1,14 +1,16 @@ // Auto-generated unit tests for transaction VaultDelete -#include -#include -#include -#include -#include #include + #include +#include +#include +#include +#include +#include + #include namespace xrpl::transactions { @@ -30,7 +32,12 @@ TEST(TransactionsVaultDeleteTests, BuilderSettersRoundTrip) auto const vaultIDValue = canonical_UINT256(); auto const memoDataValue = canonical_VL(); - VaultDeleteBuilder builder{accountValue, vaultIDValue, sequenceValue, feeValue}; + VaultDeleteBuilder builder{ + accountValue, + vaultIDValue, + sequenceValue, + feeValue + }; // Set optional fields builder.setMemoData(memoDataValue); @@ -64,6 +71,7 @@ TEST(TransactionsVaultDeleteTests, BuilderSettersRoundTrip) expectEqualField(expected, *actualOpt, "sfMemoData"); EXPECT_TRUE(tx.hasMemoData()); } + } // 2 & 4) Start from an STTx, construct a builder from it, build a new wrapper, @@ -84,7 +92,12 @@ TEST(TransactionsVaultDeleteTests, BuilderFromStTxRoundTrip) auto const memoDataValue = canonical_VL(); // Build an initial transaction - VaultDeleteBuilder initialBuilder{accountValue, vaultIDValue, sequenceValue, feeValue}; + VaultDeleteBuilder initialBuilder{ + accountValue, + vaultIDValue, + sequenceValue, + feeValue + }; initialBuilder.setMemoData(memoDataValue); @@ -117,13 +130,15 @@ TEST(TransactionsVaultDeleteTests, BuilderFromStTxRoundTrip) ASSERT_TRUE(actualOpt.has_value()) << "Optional field sfMemoData should be present"; expectEqualField(expected, *actualOpt, "sfMemoData"); } + } // 3) Verify wrapper throws when constructed from wrong transaction type. TEST(TransactionsVaultDeleteTests, WrapperThrowsOnWrongTxType) { // Build a valid transaction of a different type - auto const [pk, sk] = generateKeyPair(KeyType::Secp256k1, generateSeed("testWrongType")); + auto const [pk, sk] = + generateKeyPair(KeyType::Secp256k1, generateSeed("testWrongType")); auto const account = calcAccountID(pk); AccountSetBuilder wrongBuilder{account, 1, canonical_AMOUNT()}; @@ -136,7 +151,8 @@ TEST(TransactionsVaultDeleteTests, WrapperThrowsOnWrongTxType) TEST(TransactionsVaultDeleteTests, BuilderThrowsOnWrongTxType) { // Build a valid transaction of a different type - auto const [pk, sk] = generateKeyPair(KeyType::Secp256k1, generateSeed("testWrongTypeBuilder")); + auto const [pk, sk] = + generateKeyPair(KeyType::Secp256k1, generateSeed("testWrongTypeBuilder")); auto const account = calcAccountID(pk); AccountSetBuilder wrongBuilder{account, 1, canonical_AMOUNT()}; @@ -160,7 +176,12 @@ TEST(TransactionsVaultDeleteTests, OptionalFieldsReturnNullopt) // Transaction-specific required field values auto const vaultIDValue = canonical_UINT256(); - VaultDeleteBuilder builder{accountValue, vaultIDValue, sequenceValue, feeValue}; + VaultDeleteBuilder builder{ + accountValue, + vaultIDValue, + sequenceValue, + feeValue + }; // Do NOT set optional fields @@ -171,4 +192,4 @@ TEST(TransactionsVaultDeleteTests, OptionalFieldsReturnNullopt) EXPECT_FALSE(tx.getMemoData().has_value()); } -} // namespace xrpl::transactions +}