From f6b51f0b8b925757376cb8d6e3b7e59da5788d4b Mon Sep 17 00:00:00 2001 From: Bart Date: Fri, 18 Sep 2026 18:31:07 +0000 Subject: [PATCH] ci: Say when a package publish is a dry run (#8247) Co-authored-by: Bart <11445373+bthomee@users.noreply.github.com> --- .github/workflows/on-pr.yml | 6 ++++++ .github/workflows/reusable-package.yml | 5 ++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/on-pr.yml b/.github/workflows/on-pr.yml index 25bbaa2cc9..62a995d864 100644 --- a/.github/workflows/on-pr.yml +++ b/.github/workflows/on-pr.yml @@ -190,6 +190,12 @@ jobs: # matrix (i.e. not yet labeled "Ready to merge" or "Full CI build"). if: ${{ needs.should-run.outputs.go == 'true' && (github.event_name != 'pull_request' || contains(github.event.pull_request.labels.*.name, 'Ready to merge') || contains(github.event.pull_request.labels.*.name, 'Full CI build')) }} uses: ./.github/workflows/reusable-package.yml + with: + # A pull request builds packages to prove they still build, and publishes + # nothing. Stated rather than left to the input's default, so that changing + # that default cannot start publishing from pull requests. No secrets are + # passed either, which is the second reason a publish here cannot succeed. + publish: false upload-recipe: needs: diff --git a/.github/workflows/reusable-package.yml b/.github/workflows/reusable-package.yml index ddbb04c47c..700ec9180b 100644 --- a/.github/workflows/reusable-package.yml +++ b/.github/workflows/reusable-package.yml @@ -198,7 +198,10 @@ jobs: strategy: fail-fast: false matrix: ${{ fromJson(needs.generate-matrix.outputs.matrix) }} - name: "publish ${{ matrix.xrpld_artifact_name }}" + # The name says which of the two this is, because the job runs either way: + # with publish false it passes --dry-run and uploads nothing, and a job + # called "publish ..." succeeding on a pull request reads like a release. + name: "publish ${{ matrix.xrpld_artifact_name }}${{ !inputs.publish && ' (dry run)' || '' }}" permissions: contents: read runs-on: ["self-hosted", "Linux", "X64", "heavy"]